feat: support setting securityContext for plugin side-car containers#25
Conversation
securityContetxt for plugin side-car containerssecurityContext for plugin side-car containers
|
@shajia-deshaw code looks good but you need to squash and rewrite your commits to pass the linter: |
|
Pipeline is failing because two generated files have not been updated. For the manifest.yuaml file: The zz_generated file should be generated automatically during golang build. If not, then |
c6c9937 to
97a6155
Compare
|
@Agalin The current CI error doesn't seem to be related to this PR's change? |
|
Yeah, I've noticed. 😞 Will try to fix it today. Also I believe we should split CI into smaller parts, it's pretty unreadable as-is. |
|
@shajia-deshaw if you could rebase, I hope this will be merge'able. 🙂 |
…tion` Enable PSA compliance for the plugin side-car through optional `SecurityContext` field in `Archive` spec. Maintains backward compatibility with nil defaults. Signed-off-by: Afeedh Shaji <Afeedh.Shaji@deshaw.com>
|
Looks like we're really unlucky and, between my fix and the CI re-run, Task maintainers have tagged a few new releases but not published them, causing |
|
Thanks for merging, @Agalin! Can I know the new release version so I can use it? |
|
Ah, nvm. Noticed this PR: #28 - thanks! |
Unit tests are passing:
I've also tested this in our restricted cluster environment and things are now working as expected.
Fixes: #24