fix: handle empty CurrentPrimary in isStreamingAvailable#65
Merged
Agalin merged 1 commit intoMay 20, 2026
Merged
Conversation
ermakov-oleg
force-pushed
the
fix/streaming-available-check
branch
from
c8846cf to
afbf18d
Compare
Port of upstream PR cloudnative-pg#604. When CurrentPrimary is empty (first instance), streaming is not available — prevents incorrect WAL predictions with custom segment sizes during restore. Signed-off-by: ermakov-oleg <ermakovolegs@gmail.com>
ermakov-oleg
force-pushed
the
fix/streaming-available-check
branch
from
afbf18d to
49a622f
Compare
Agalin
approved these changes
May 20, 2026
Agalin
left a comment
Agalin
left a comment
Collaborator
There was a problem hiding this comment.
Hmm. I'm pretty sure the early archival try is safe (we actually run databases with bigger WAL segments in production). Still worth fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of upstream #604
Problem: When a brand-new cluster is starting,
cluster.Status.CurrentPrimaryis an empty string until the first pod becomes primary. TheisStreamingAvailable()function did not handle this case — it fell through to logic that assumed a non-empty primary name, potentially returning incorrect results and causing WAL archiving attempts before the cluster is ready.Fix: Added an early return
falsewhenCurrentPrimary == "", explicitly handling the bootstrapping phase. Streaming replication cannot be available if no primary has been elected yet.