feat: allow easier configuration of matcher #2760
Conversation
Signed-off-by: Chris Laprun <[email protected]>
...io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
Outdated
Show resolved
Hide resolved
| @@ -54,6 +62,13 @@ public void configureWith(KubernetesDependentResourceConfig<R> config) { | |||
| this.kubernetesDependentResourceConfig = config; | |||
| } | |||
|
|
|||
| public void setMatcher(SSABasedGenericKubernetesResourceMatcher<R> matcher) { | |||
| if (this.matcher != defaultMatcher) { | |||
There was a problem hiding this comment.
I'm not sure how big the matcher object can be, but this could be a boolean.
There was a problem hiding this comment.
Not sure I'm following
There was a problem hiding this comment.
I mean you don't need to keep the defaultMatcherin the field if it's only used to verify that the matcher is set only once. It can be a boolean that is flipped when first set so it's only taking a byte (usually) instead of the size of the defaultMatcher object.
There was a problem hiding this comment.
Yes, figured it out, I have done that change locally, checking with QOSDK before pushing
Signed-off-by: Chris Laprun <[email protected]>
| private final boolean garbageCollected = this instanceof GarbageCollected; | ||
| private KubernetesDependentResourceConfig<R> kubernetesDependentResourceConfig; | ||
| private volatile Boolean useSSA; | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private SSABasedGenericKubernetesResourceMatcher<R> matcher = defaultMatcher; | ||
| private SSABasedGenericKubernetesResourceMatcher<R> matcher = |
There was a problem hiding this comment.
Shouldn't this be this rather part of the configuration?
The current approach is that name and class and config are the params and configuration contains everything else. This might go there just as well.
There was a problem hiding this comment.
Wanted to keep it simple first but it definitely could go on the config.
...io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
Show resolved
Hide resolved
Signed-off-by: Chris Laprun [email protected]