Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ PoC: Client-side permission evaluation #1804

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 221976e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67be7a6123f4f700086ba201
😎 Deploy Preview https://deploy-preview-1804--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 2.40460% with 1867 lines in your changes missing coverage. Please review.

Project coverage is 50.32%. Comparing base (4ecef20) to head (5ab5ea1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/authorization/rbac.go 3.78% 305 Missing ⚠️
...rnetes/pkg/apis/rbac/v1/zz_generated.conversion.go 1.36% 264 Missing and 24 partials ⚠️
.../kubernetes/pkg/apis/rbac/zz_generated.deepcopy.go 0.00% 275 Missing ⚠️
...ation/internal/kubernetes/pkg/apis/rbac/helpers.go 0.00% 208 Missing ⚠️
...al/kubernetes/pkg/registry/rbac/validation/rule.go 0.97% 203 Missing ⚠️
...on/internal/kubernetes/pkg/apis/rbac/v1/helpers.go 0.00% 121 Missing ⚠️
...kubernetes/plugin/pkg/auth/authorizer/rbac/rbac.go 6.08% 108 Missing ⚠️
...l/kubernetes/pkg/registry/rbac/escalation_check.go 0.00% 89 Missing ⚠️
.../kubernetes/pkg/apis/rbac/v1/evaluation_helpers.go 0.00% 86 Missing ⚠️
internal/operator-controller/applier/helm.go 8.62% 52 Missing and 1 partial ⚠️
... and 6 more

❗ There is a different number of reports uploaded between BASE (4ecef20) and HEAD (5ab5ea1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4ecef20) HEAD (5ab5ea1)
unit 2 1
e2e 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1804       +/-   ##
===========================================
- Coverage   68.34%   50.32%   -18.02%     
===========================================
  Files          62       76       +14     
  Lines        5117     7020     +1903     
===========================================
+ Hits         3497     3533       +36     
- Misses       1390     3227     +1837     
- Partials      230      260       +30     
Flag Coverage Δ
e2e 35.23% <2.40%> (-16.39%) ⬇️
unit 40.89% <0.94%> (-15.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford force-pushed the rbac-auth branch 2 times, most recently from 45a7311 to 635379c Compare February 25, 2025 18:27
@joelanford
Copy link
Member Author

codecov is clearly not honoring this change or I'm doing it wrong....

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants