Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Configuration interface #1847

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thetechnick
Copy link
Contributor

Implements RFC "Arbitrary Configuration".

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Implements RFC "Arbitrary Configuration".
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b7984ba
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67c9afd84515a1000941e423
😎 Deploy Preview https://deploy-preview-1847--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thetechnick thetechnick changed the title Add Configuration interface ✨ Add Configuration interface Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 26.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 67.94%. Comparing base (e69f1ec) to head (b7984ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/v1/zz_generated.deepcopy.go 0.00% 31 Missing and 1 partial ⚠️
...rnal/operator-controller/applier/watchnamespace.go 68.75% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   68.39%   67.94%   -0.46%     
==========================================
  Files          63       64       +1     
  Lines        5136     5179      +43     
==========================================
+ Hits         3513     3519       +6     
- Misses       1392     1426      +34     
- Partials      231      234       +3     
Flag Coverage Δ
e2e 51.08% <12.00%> (-0.44%) ⬇️
unit 55.66% <26.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant