🌱 Update github.com/containers/image/v5 to v5.34.1 #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| $(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR) | ||
| $(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR) | ||
| GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) rbac:roleName=manager-role paths="./internal/catalogd/..." output:rbac:artifacts:config=$(KUSTOMIZE_CATD_RBAC_DIR) | ||
| GOFLAGS="-tags=$(GO_BUILD_TAGS)" $(CONTROLLER_GEN) webhook paths="./internal/catalogd/..." output:webhook:artifacts:config=$(KUSTOMIZE_CATD_WEBHOOKS_DIR) |
There was a problem hiding this comment.
It will not work :-(
I am proposing we add its support here: kubernetes-sigs/controller-tools#1158 (comment)
But see has no env var or flag that allow us to pass the build tag so far: https://github.com/kubernetes-sigs/controller-tools/blob/main/pkg/loader/loader.go#L373-L379
The best away so far is replace the dep to downgrade it, see: #1846
There was a problem hiding this comment.
I think downgrade is dangerous, and the best way would be to move things around instead (short of fixing controller-tools)
openshift-merge-robot
added
the
needs-rebase
Add GOFLAGS to controller-gen invocations This is to deal with gpgme inclusion weirdness Signed-off-by: Todd Short <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GOFLAGS to controller-gen invocations
This is to deal with gpgme inclusion weirdness
Description
Reviewer Checklist