-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 (doc): Add under the docs/draft how to profilling with pprof #1876
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold until we get merged #1875 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
==========================================
- Coverage 69.00% 68.94% -0.06%
==========================================
Files 66 66
Lines 5236 5236
==========================================
- Hits 3613 3610 -3
- Misses 1392 1394 +2
- Partials 231 232 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed in the user docs.
The docs
folder hosts the OLMv1 user docs, and this is a dev doc.
Hi @anik120 Thank you for your input and help. As far I understand our documentation as a whole is valid for both end users and maintainers. IHMO: I believe it is important to have documentation that explains how to enable and use it with the components. This will be helpful for end users when they encounter issues and need gather further details, as well as for us (maintainers) when we are looking to debug an issue |
/hold cancel We can move forward now |
This one as just a doc to show we can use pprof with the components
The usage of pprof can help us solve bugs and analyse issues
It is blocked by #1875 because we need to add a flag.
It is related to (Motivated by):