Skip to content

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Oct 13, 2025

Description of the change:
revert app code to before refactoring, but enhance testing to address the changes since then

Motivation for the change:
in #1169 I was attempting to address a semver catalog template expansion error which ignored an X/arch/kind transition on the last edge. In discussion at the time, we had consensus that it only made sense to generate replaces links from minor version bundles to previous minor version head (meaning the previous minor version, maximum patch version, hereafter referred to as "prev-Z-max") in the context of generating major-version channels from the semver template.
The thinking had been that we felt that folks would want to exert controls on generated minor channels and wouldn't want generated prev-Z-max linkage.
That enabled some code refactoring for simplicity, which did not include the prev-Z-max linkage for generated minor version channels.

It turns out in retrospect that we like prev-Z-max for generated minor channels, and folks have asked for it to be re-added. Unfortunately (for me), we have addressed several issues in the same area so we couldn't merely revert to the old commit.

This PR includes the older implementation with tests that validate/enforce the prev-Z-max for generated minor version channels.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Contributor Author

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.35%. Comparing base (8d4a5f9) to head (f8ead57).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   55.27%   55.35%   +0.08%     
==========================================
  Files         136      136              
  Lines       15976    15997      +21     
==========================================
+ Hits         8830     8855      +25     
+ Misses       5991     5987       -4     
  Partials     1155     1155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant