revert channel-scoped semver template expansion to edge-scoped #1813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
revert app code to before refactoring, but enhance testing to address the changes since then
Motivation for the change:
in #1169 I was attempting to address a semver catalog template expansion error which ignored an X/arch/kind transition on the last edge. In discussion at the time, we had consensus that it only made sense to generate replaces links from minor version bundles to previous minor version head (meaning the previous minor version, maximum patch version, hereafter referred to as "prev-Z-max") in the context of generating major-version channels from the semver template.
The thinking had been that we felt that folks would want to exert controls on generated minor channels and wouldn't want generated prev-Z-max linkage.
That enabled some code refactoring for simplicity, which did not include the prev-Z-max linkage for generated minor version channels.
It turns out in retrospect that we like prev-Z-max for generated minor channels, and folks have asked for it to be re-added. Unfortunately (for me), we have addressed several issues in the same area so we couldn't merely revert to the old commit.
This PR includes the older implementation with tests that validate/enforce the prev-Z-max for generated minor version channels.
Reviewer Checklist
/docs