Skip to content

[DREAM-712] Support Angular v21-22 - #212

Merged
myabc merged 3 commits into
mainfrom
code-maintenance/angular-22
Jun 13, 2026
Merged

[DREAM-712] Support Angular v21-22#212
myabc merged 3 commits into
mainfrom
code-maintenance/angular-22

Conversation

@myabc

@myabc myabc commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

What are you trying to accomplish?

Upgrades @openproject/octicons-angular dev toolchain to Angular v22 and TypeScript 6.0, and widens peer support to Angular v21–v22.

  • Bumps Angular framework/CLI/build dev dependencies ^21.0.x^22.0.0 (ng update @angular/core@22 @angular/cli@22 --force)
  • Bumps angular-eslint 21.3.122.0.0 and ng-packagr ^21^22
  • Bumps typescript ^5.9.3^6.0.3 (Angular v22 prerequisite, aligns with downstream)
  • Widens peerDependencies for @angular/core and @angular/common to >=21.0.0 <23.0.0
  • Suppresses the new nullishCoalescingNotNullable / optionalChainNotNullable extended diagnostics in tsconfig.lib*.json / tsconfig.spec.json

Screenshots

No visual changes.

Integration

Downstream / related PRs:

Issues affected

https://community.openproject.org/wp/DREAM-712

Risk Assessment

  • Low risk
  • Medium risk — isolated dev/build dependency bump; published library API unchanged.
  • High risk

What approach did you choose and why?

Used the official ng update migration with --force, then reinstated the peer dependency range so consumers on Angular 21 or 22 are both supported. TypeScript 6.0.3 matches the downstream OpenProject and primer_view_components upgrades so the whole stack stays on one compiler version.

Anything you want to highlight for special attention from reviewers?

Dev/build toolchain only — no runtime or generated-icon output change.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Force updates Angular dependencies:

    ng update @angular/core@22 @angular/cli@22 --force

And performs automated upgrade. Also updates angular-eslint.

https://community.openproject.org/wp/DREAM-712
@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 91ca35b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

myabc added 2 commits June 8, 2026 11:26
Reinstates peerDependencies added in 237e789, updating for latest
Angular versions.

https://community.openproject.org/wp/DREAM-712
@myabc
myabc force-pushed the code-maintenance/angular-22 branch from 19c61af to 91ca35b Compare June 8, 2026 10:27
@myabc
myabc marked this pull request as ready for review June 8, 2026 10:27
Copilot AI review requested due to automatic review settings June 8, 2026 10:27
@myabc
myabc requested a review from HDinger June 8, 2026 10:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @openproject/octicons-angular workspace configuration to build/test against Angular v22 while declaring compatibility with Angular v21–v22, aligning the Angular integration package with the repository’s release process.

Changes:

  • Bump Angular Angular-package dev dependencies to ^22.0.0 (including ng-packagr and angular-eslint) and update TypeScript to ^6.0.3.
  • Update Angular peer dependency range to >=21.0.0 <23.0.0 (Angular v21–v22).
  • Add angularCompilerOptions.extendedDiagnostics.checks suppressions for nullishCoalescingNotNullable and optionalChainNotNullable across Angular tsconfig variants.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/octicons_angular/tsconfig.spec.json Adds Angular compiler extended diagnostics suppression for spec compilation.
lib/octicons_angular/tsconfig.lib.prod.json Adds extended diagnostics suppression alongside partial compilation mode.
lib/octicons_angular/tsconfig.lib.json Adds extended diagnostics suppression for library compilation.
lib/octicons_angular/package.json Upgrades Angular dev deps to v22, updates peer range to v21–v22, bumps TypeScript.
.changeset/tricky-cups-shave.md Records a minor release note for Angular v21–v22 support.

@myabc myabc changed the title [DREAM-712] Upgrade Angular to v22 [DREAM-712] Support Angular v21-22 Jun 8, 2026
@myabc

myabc commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

@HDinger not sure if we need a changeset?

@HDinger HDinger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@myabc
myabc merged commit 51c5406 into main Jun 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants