[chore] add forms dsl input for filterable tree views

[Kharonus]

What are you trying to accomplish?

• get a forms dsl input filterable_tree_view

What approach did you choose and why?

• pass every input argument unchanged to filterable tree view component
• no default logic
• label defaults to nil

[Kharonus]

Ahoi @myabc ,

you asked or adding the filterable tree view as a forms dsl input. Can you check my code here? I'm not very used to those components, do I miss something obvious? For my use case this works quite fine. Is the simple approach of not applying any defaults correct?

[myabc]

@Kharonus yes, this looks good! thanks for doing rolling this into an input.

A few small asks:

• a spec for the input. This recently-added spec should be a good template: spec/lib/primer/open_project/forms/segmented_control_spec.rb.
• add a filterable_tree_view example to spec/lib/primer/open_project/forms/dsl/input_methods_spec.rb as well - admittedly this spec is a bit stupid but it exists to verify that attribute help text options are correctly handled.

[myabc]

This probably might need a bit more thought after all - I'll try to discuss with @HDinger tomorrow.

In your particular case you don't need to render a label, which is fine. However most "inputs" support a label - and for symmetry we should support it here.

This might mean:

• forwarding label: and visually_hide_label: to filter_input_arguments:
• or alternatively, wrap in a fieldset, with the label being a rendered as a legend.

Either way this brings up an interesting discussion of what the "input" actually consists of in this particular case!

[Kharonus]

This probably might need a bit more thought after all - I'll try to discuss with @HDinger tomorrow.

In your particular case you don't need to render a label, which is fine. However most "inputs" support a label - and for symmetry we should support it here.

This might mean:

• forwarding label: and visually_hide_label: to filter_input_arguments:
• or alternatively, wrap in a fieldset, with the label being a rendered as a legend.

Either way this brings up an interesting discussion of what the "input" actually consists of in this particular case!

Yes, I suspected as much, when I saw that label is actually mandatory, but the filterable tree view doesn't have one. So I set it to nil in the initialize.

Please tell me, when you discussed a solution.

//cc @HDinger @myabc

[myabc]

@HDinger I chose to always render the bottom margin - as (GH Primer, non-advanced) check box group does.

[myabc]

@HDinger should we add documentation for this input to the Lookbook in this PR? Or take care of it as a follow-up?

[github-actions]

Warning

Flaky specs

• rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]

[Kharonus]

tested, looks good for me.