[DREAM-388] Add a 'Security' page in Account settings - #23602
Merged
HDinger merged 5 commits intoJun 15, 2026
Conversation
HDinger
force-pushed
the
feature/dream-388-add-a-security-page-in-account-settings
branch
from
June 8, 2026 13:16
26409a2 to
457a01b
Compare
HDinger
marked this pull request as ready for review
June 8, 2026 13:16
HDinger
force-pushed
the
feature/dream-388-add-a-security-page-in-account-settings
branch
from
June 9, 2026 07:45
457a01b to
afd65c6
Compare
bsatarnejad
requested changes
Jun 10, 2026
bsatarnejad
left a comment
bsatarnejad
left a comment
Contributor
There was a problem hiding this comment.
The devider is cut somewhere in the middle of the page.
Overall looks good to me, but what do you think about having them in separate tabs?
… after wrong password is correct
HDinger
force-pushed
the
feature/dream-388-add-a-security-page-in-account-settings
branch
3 times, most recently
from
June 11, 2026 13:20
5f45f42 to
42b84dc
Compare
… in one menu, change button colors, use Primer components for inlineMessage
HDinger
force-pushed
the
feature/dream-388-add-a-security-page-in-account-settings
branch
from
June 12, 2026 06:13
42b84dc to
e24bbae
Compare
|
Warning Flaky specs
|
bsatarnejad
requested changes
Jun 12, 2026
| # See COPYRIGHT and LICENSE files for more details. | ||
| #++ | ||
|
|
||
| class My::PasswordForm < ApplicationForm |
Contributor
There was a problem hiding this comment.
Can we have inline validation or show a meaningful error message:
Contributor
Author
There was a problem hiding this comment.
I will exclude that into a separate ticket as it requires some more work and the freeze is coming ❄️
HDinger
deleted the
feature/dream-388-add-a-security-page-in-account-settings
branch
June 15, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/DREAM-388
What are you trying to accomplish?
Screenshots