Feature/STC-746: Adapt meeting PDF exports for semantic identifiers - #23708
Merged
akabiru merged 1 commit intoJun 15, 2026
Merged
Conversation
Agenda item titles and work package outcomes hardcoded the numeric id. Using formatted_id renders the project-based identifier in semantic mode, matching the meeting page rendering.
3 tasks
|
Warning Flaky specs
|
akabiru
marked this pull request as ready for review
June 12, 2026 11:39
akabiru
deleted the
feature/stc-746-adapt-meeting-pdf-exports-for-semantic-identifiers
branch
June 15, 2026 09:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/STC-746
What are you trying to accomplish?
On instances configured with project-based work package identifiers, meeting PDF exports still showed the numeric database id. This PR makes the agenda and minutes templates render the configured identifier instead, so a work package agenda item exports as
Task PROD-42 Improve onboarding flowrather thanTask #39 Improve onboarding flow. The same applies to work package outcomes. Work package mentions inside agenda item notes already resolved to the configured identifier through the shared markdown-to-PDF pipeline, and the meeting exporter specs now cover that path too.Screenshots
Before (classic identifiers)
stc746-minutes-classic-before.pdf
After (semantic identifiers)
stc746-minutes-semantic-after.pdf
What approach did you choose and why?
The agenda title and outcome lines built their label with the raw numeric id, while the rest of the application (the meeting page itself, the work package PDF exports, mention expansion) renders identifiers through
formatted_id, which returns the hash-prefixed numeric id in classic mode and the project-based identifier in semantic mode. The fix is to build the meeting PDF labels the same way, through a single helper shared by the agenda item title and the outcome line. Link URLs needed no change since URL helpers already resolve to the configured identifier.Undisclosed work package references (where the viewer lacks permission) keep showing the numeric id, consistent with how the meeting page renders them.
Merge checklist