Skip to content

Implementation/STC-783: Adapt PDF export of timesheets for semantic identifiers #23712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akabiru merged 1 commit into from
Jun 12, 2026
Merged

Implementation/STC-783: Adapt PDF export of timesheets for semantic identifiers #23712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/reporting/app/workers/cost_query/pdf/timesheet_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def build_table_subject_cell(entry)

href = url_helpers.work_package_url(entry.entity)
{
content: "#{make_link_href(href, "##{entry.entity.id}")} #{entry.entity.subject || ''}",
content: "#{make_link_href(href, entry.entity.formatted_id)} #{entry.entity.subject || ''}",
inline_format: true
}
end
Expand Down
12 changes: 12 additions & 0 deletions modules/reporting/spec/workers/cost_query/pdf/timesheet_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,16 @@ def expected_document(with_times_column)
expect(subject).to eq expected_document(false)
end
end

context "with semantic work package identifiers",
with_settings: { work_packages_identifier: "semantic", allow_tracking_start_and_end_times: false } do
before do
user_time_entry.entity.update_columns(identifier: "PROD-42", sequence_number: 42)
end

it "renders the semantic identifier in the work package column" do
expect(subject).to include("PROD-42")
expect(subject).not_to include("##{user_time_entry.entity.id}")
end
end
end
Loading