Skip to content

Fix flaky specs: create_spec.rb[1:12:3:2:1] and switch_types_spec.rb[1:1:2] #23784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix flaky specs: create_spec.rb[1:12:3:2:1] and switch_types_spec.rb[1:1:2] #23784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b4f89
Initial plan
Copilot Jun 16, 2026
d60debc
Fix flaky specs: remove openSelectField race condition and add Turbo …
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spec/features/projects/create_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,11 +392,13 @@
# Step 1: Select workspace type
click_on "Continue"

# Step 2: Fill in project details
# Step 2: Fill in project details; wait to ensure Turbo has fully rendered step 2
expect(page).to have_text("2 of") # rubocop:disable RSpec/ExpectInHook
Comment on lines +395 to +396

@myabc myabc Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely the right strategy for dealing with timing issues.. my only issue is the actual expectation. Can we not scope the text to a particular element or region..

Suggested change
# Step 2: Fill in project details; wait to ensure Turbo has fully rendered step 2
expect(page).to have_text("2 of") # rubocop:disable RSpec/ExpectInHook
expect(page).to have_role(:progressbar, text: "2 of") # rubocop:disable RSpec/ExpectInHook

or (if using a <progress> element itself):

Suggested change
# Step 2: Fill in project details; wait to ensure Turbo has fully rendered step 2
expect(page).to have_text("2 of") # rubocop:disable RSpec/ExpectInHook
expect(page).to have_element(:progress, value: "2") # rubocop:disable RSpec/ExpectInHook

fill_in "Name", with: "Foo bar"
click_on "Continue"

# Step 3: Fill in required custom field
# Step 3: Fill in required custom field; wait to ensure Turbo has fully rendered step 3
expect(page).to have_text("3 of") # rubocop:disable RSpec/ExpectInHook
fill_in "Required Foo", with: "Required value"
end

Expand Down
1 change: 0 additions & 1 deletion spec/features/work_packages/table/switch_types_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ def req_text_field

# Now switch back to a type without the required CF
type_field.activate!
type_field.openSelectField

@ulferts ulferts Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not fix the issue. The problem is a race condition in the production code where the schema is expected to be there, but sometimes isn't, on the required custom field.

There is an attempted fix in the form of a PR but I wanted to dig deeper if time permits to find out if the schema access can be safeguarded instead of attempting to address the issue on accessing the schema. But my proposal might already be good enough for now.

type_field.set_value type_task.name

wp_table.expect_and_dismiss_toaster(
Expand Down
Loading