Skip to content

Chore: Make the flaky-spec Copilot prompt request a standalone PR off dev - #23785

Merged
akabiru merged 1 commit into
devfrom
chore/flaky-spec-copilot-prompt-standalone
Jun 16, 2026
Merged

Chore: Make the flaky-spec Copilot prompt request a standalone PR off dev#23785
akabiru merged 1 commit into
devfrom
chore/flaky-spec-copilot-prompt-standalone

Conversation

@akabiru

@akabiru akabiru commented Jun 16, 2026

Copy link
Copy Markdown
Member

When the flaky-spec reporter's @copilot prompt said "open a separate pull request", Copilot read "separate" as a follow-up stacked on the triggering PR (example): it echoed that PR's title, based its branch on it, and framed the work as merging back into it. That coupling also meant the agent session died once the triggering PR merged, since its base ref disappeared. The prompt now states the task is standalone, unrelated to the triggering PR, to branch from origin/dev and target dev, to title the PR after the spec(s) it fixes, and to use the PR description for the root cause and the fix. The triggering PR number stays only as a backlink for traceability.

No work package — follow-up to the flaky-spec Copilot delegation merged in #23773.

Preview

How the posted comment renders — expand for the refined prompt:


Warning

Flaky specs

  • rspec ./spec/features/projects/create_spec.rb[1:12:3:2:1]
  • rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23755, linked for reference only):

- `rspec ./spec/features/projects/create_spec.rb[1:12:3:2:1]`
- `rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]`

Treat this as a standalone task, unrelated to PR #23755. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23755 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the flakiness. Title the PR after the spec(s) it fixes, and use the PR description to explain the root cause and how the change resolves it. Request a review from @akabiru.

Copilot read "open a separate pull request" as a follow-up stacked on
the triggering PR: it inherited that PR's title and based its branch on
it, so the agent session died when the base PR merged. The prompt now
pins the work as standalone off origin/dev, targeting dev, with a title
naming the fixed specs and a description covering root cause and fix.
@akabiru
akabiru requested a review from Copilot June 16, 2026 18:45
@akabiru
akabiru marked this pull request as ready for review June 16, 2026 18:46
@akabiru akabiru self-assigned this Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the flaky-spec reporter’s delegated @copilot prompt (posted as a PR comment from CI) to explicitly instruct Copilot to open a standalone follow-up PR based off origin/dev, avoiding accidental “stacked-on-the-triggering-PR” behavior and the associated session/base-ref coupling.

Changes:

  • Rewords the delegated prompt to clarify the triggering PR is reference-only and the task is standalone.
  • Adds explicit branching/targeting instructions (origin/dev → PR to dev) and guidance for PR title/description content.

@akabiru
akabiru merged commit 4205c94 into dev Jun 16, 2026
17 checks passed
@akabiru
akabiru deleted the chore/flaky-spec-copilot-prompt-standalone branch June 16, 2026 18:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants