Skip to content

[DREAM-726] Add blankslate for favorited projects when there are none - #23792

Merged
HDinger merged 1 commit into
release/17.6from
bug/dream-726-add-blankslate-for-favorited-projects-when-there-are-none
Jun 22, 2026
Merged

[DREAM-726] Add blankslate for favorited projects when there are none#23792
HDinger merged 1 commit into
release/17.6from
bug/dream-726-add-blankslate-for-favorited-projects-when-there-are-none

Conversation

@HDinger

@HDinger HDinger commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/DREAM-726

What are you trying to accomplish?

Show special node when there are no favourite projects yet

Screenshots

Bildschirmfoto 2026-06-17 um 10 49 42

@HDinger HDinger added this to the 17.6.x milestone Jun 17, 2026

@bsatarnejad bsatarnejad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Just a minor thing:
To me it looks that it is not really aligned. Another issue is the spell of favorite, favorite is american english while favourite is british engliah and if I'm not mistaken we follow american english.

Image

@HDinger
HDinger force-pushed the bug/dream-726-add-blankslate-for-favorited-projects-when-there-are-none branch from 10f9c51 to 7768d20 Compare June 22, 2026 06:21
@HDinger
HDinger changed the base branch from dev to release/17.6 June 22, 2026 06:21
@HDinger

HDinger commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

LGTM 👍🏼 Just a minor thing: To me it looks that it is not really aligned. Another issue is the spell of favorite, favorite is american english while favourite is british engliah and if I'm not mistaken we follow american english.
Image

The intendation is the same as for the tree with search results.
Bildschirmfoto 2026-06-22 um 08 22 17

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23792, linked for reference only):

- `rspec ./spec/features/projects/lists/filters_spec.rb[1:6:1]`

Treat this as a standalone task, unrelated to PR #23792. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23792 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@HDinger
HDinger merged commit 4e9d006 into release/17.6 Jun 22, 2026
16 checks passed
@HDinger
HDinger deleted the bug/dream-726-add-blankslate-for-favorited-projects-when-there-are-none branch June 22, 2026 06:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants