[XWI-153] Renamed "Internal wiki" → "Project wiki" by shiroginne · Pull Request #24632 · opf/openproject

shiroginne · 2026-08-06T12:26:44Z

Ticket

XWI-153

What are you trying to accomplish?

Self-titled.

Screenshots

Merge checklist

Added/updated tests
Added/updated documentation in Lookbook (patterns, previews, etc)
Tested major browsers (Chrome, Firefox, Edge, ...)

github-actions · 2026-08-06T12:53:14Z

Warning

Flaky specs

rspec ./modules/overviews/spec/features/managing_dashboard_page_spec.rb[1:1:1]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24632, linked for reference only):

- `rspec ./modules/overviews/spec/features/managing_dashboard_page_spec.rb[1:1:1]`

Treat this as a standalone task, unrelated to PR #24632. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24632 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

github-actions · 2026-08-06T14:50:21Z

Warning

Flaky specs

rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24632, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`

Treat this as a standalone task, unrelated to PR #24632. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24632 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

NobodysNightmare · 2026-08-07T11:24:44Z


 > [!NOTE]
-> As of OpenProject 17.6, this setting **does not affect the regular OpenProject Wiki module**. Projects can continue to use their project wiki as usual when the **Wiki** module is enabled under **Project settings → Modules**. This WILL CHANGE in the upcoming releases. We therefore advise to only disable the internal provider, if you are not planning to use internal wikis at all.
+> As of OpenProject 17.6, this setting **does not affect the regular OpenProject Wiki module**. Projects can continue to use their project wiki as usual when the **Wiki** module is enabled under **Project settings → Modules**. This WILL CHANGE in the upcoming releases. We therefore advise to only disable project wikis if you are not planning to use them at all.


❗ Outdated

We changed this. Question is whether that change was part of 17.7 or 17.8 (CC @mereghost )

(also docs below are outdated w.r.t. this)

To clarify: The whole NOTE box that I commented at here is outdated. As far as I can tell, since 17.7 we now do prevent the creation of project wikis when the global setting is disabled.

Also texts further down on this page here need to be adapted accordingly.

Yes, I think you are right. This is however the change for 17.7. I'll do it on that (17.7) branch.

NobodysNightmare · 2026-08-07T11:27:09Z


 > [!TIP]
-> If the internal wiki provider is disabled by your OpenProject administrator for your instance, this page is not visible and the project wiki cannot be enabled.
+> If project wikis are disabled by your OpenProject administrator for your instance, this page is not visible and the project wiki cannot be enabled.


OMG, and I am about to change this behaviour with 17.8, where the settings page remains visible...

So we partially updated our docs, but not completely 🙈

NobodysNightmare

I can't find anything wrong with the changes of this PR, except for the side-find of other docs being outdated (and me being concerned that we'll cause merge conflicts if we fix those).

github-actions · 2026-08-07T12:39:08Z

Warning

Flaky specs

rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24632, linked for reference only):

- `rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #24632. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24632 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

shiroginne · 2026-08-07T12:53:48Z

Thanks! I'll contact @MayaBerd regarding the docs; we'll cook something up (I hope 😅)

NobodysNightmare

ah, spotted something I overlooked at first

NobodysNightmare · 2026-08-07T13:04:40Z

        one: Inline page link
        other: Inline page links
-      wikis/internal_provider: Internal wiki
+      wikis/internal_provider: Project wikis


This is a very generic translation for wikis/internal_provider. Thus it has to be either:

always singular

or properly pluralized

You can look at the surrounding translations for proper pluralization. This also means that if you have places that currently do something like InternalProvider.model_name.human, you might want to replace those with InternalProvider.model_name.human(count: 2).

github-actions · 2026-08-07T13:54:05Z

Warning

Flaky specs

rspec ./spec/features/roles/report_spec.rb[1:1]
rspec ./spec/features/roles/report_spec.rb[1:3]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24632, linked for reference only):

- `rspec ./spec/features/roles/report_spec.rb[1:1]`
- `rspec ./spec/features/roles/report_spec.rb[1:3]`

Treat this as a standalone task, unrelated to PR #24632. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24632 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

…ikis

github-actions · 2026-08-11T10:44:54Z

Warning

Flaky specs

rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]
rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24632, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`
- `rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]`

Treat this as a standalone task, unrelated to PR #24632. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24632 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

shiroginne self-assigned this Aug 6, 2026

shiroginne marked this pull request as ready for review August 7, 2026 07:54

shiroginne requested a review from a team August 7, 2026 07:54

NobodysNightmare requested a review from MayaBerd August 7, 2026 11:23

NobodysNightmare reviewed Aug 7, 2026

View reviewed changes

NobodysNightmare approved these changes Aug 7, 2026

View reviewed changes

NobodysNightmare requested changes Aug 7, 2026

View reviewed changes

NobodysNightmare reviewed Aug 7, 2026

View reviewed changes

shiroginne added 4 commits August 7, 2026 15:22

Renamed "Internal wiki" → "Project wiki"

1152a15

Update docs (CI)

58d64bf

Rename

6231245

Update project_internal_wiki_component.html.erb

c15bb53

shiroginne force-pushed the bug/xwi-153-rename-internal-wiki-to-project-wikis branch from 6e51ee6 to c15bb53 Compare August 7, 2026 13:22

Fix pluralization issue

4f99ea1

shiroginne added 3 commits August 10, 2026 16:06

Merge branch 'dev' into bug/xwi-153-rename-internal-wiki-to-project-w…

341f397

…ikis

Merge branch 'dev' into bug/xwi-153-rename-internal-wiki-to-project-w…

913f718

…ikis

Update project_internal_wiki_component.html.erb

c7f44d2

shiroginne merged commit 13ce6e9 into dev Aug 11, 2026
19 checks passed

shiroginne deleted the bug/xwi-153-rename-internal-wiki-to-project-wikis branch August 11, 2026 11:25

github-actions Bot locked and limited conversation to collaborators Aug 11, 2026

Uh oh!

Conversation

shiroginne commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ticket

What are you trying to accomplish?

Screenshots

Merge checklist

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

NobodysNightmare Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

NobodysNightmare Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

NobodysNightmare Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

MayaBerd Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

NobodysNightmare Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

NobodysNightmare left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

shiroginne commented Aug 7, 2026

Uh oh!

NobodysNightmare left a comment

Choose a reason for hiding this comment

Uh oh!

NobodysNightmare Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

shiroginne Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

shiroginne commented Aug 6, 2026 •

edited

Loading