Keep new and removed state of non-working days on error state - #24651
Conversation
|
Warning This pull request does not link an OpenProject work package. Please add a link to the work package in the description, or reference it in the |
cbliard
left a comment
There was a problem hiding this comment.
Works well. Thanks.
The only thing that is not preserved is when one wants to rename a day, they can't do it easily: they have to remove the day and add it again with another name. When doing so and the cahnge cannot be applied, then the day is lost: it only keeps the removal and not the addition, but that's really an edge case.
Good point, but I think we can ignore that edge case in favor of a better blocking when an active job is processing |
When the non working days cannot be saved for some reason, keep them around so the user can either correct their mistake, or wait for the changes to be applied.