Skip to content

Keep new and removed state of non-working days on error state - #24651

Merged
oliverguenther merged 1 commit into
release/17.7from
fix/keep-non-working-days-on-error
Aug 7, 2026
Merged

Keep new and removed state of non-working days on error state#24651
oliverguenther merged 1 commit into
release/17.7from
fix/keep-non-working-days-on-error

Conversation

@oliverguenther

Copy link
Copy Markdown
Member

When the non working days cannot be saved for some reason, keep them around so the user can either correct their mistake, or wait for the changes to be applied.

@oliverguenther
oliverguenther requested a review from cbliard August 7, 2026 06:00
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

This pull request does not link an OpenProject work package.

Please add a link to the work package in the description, or reference it in the
title in square brackets, e.g. [SLUG-123] My title here.

@cbliard cbliard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Thanks.

The only thing that is not preserved is when one wants to rename a day, they can't do it easily: they have to remove the day and add it again with another name. When doing so and the cahnge cannot be applied, then the day is lost: it only keeps the removal and not the addition, but that's really an edge case.

@oliverguenther
oliverguenther merged commit 42ab87f into release/17.7 Aug 7, 2026
12 of 13 checks passed
@oliverguenther
oliverguenther deleted the fix/keep-non-working-days-on-error branch August 7, 2026 09:17
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
@oliverguenther

Copy link
Copy Markdown
Member Author

When doing so and the cahnge cannot be applied, then the day is lost: it only keeps the removal and not the addition, but that's really an edge case.

Good point, but I think we can ignore that edge case in favor of a better blocking when an active job is processing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants