Skip to content

[COMMS-934] Drop primary-version nomenclature from comments and cost query join - #24656

Merged
akabiru merged 1 commit into
implementation/comms-934-adjust-workpackageattimerepresenter-with-target_verisonsfrom
chore/drop-primary-version-nomenclature
Aug 7, 2026
Merged

[COMMS-934] Drop primary-version nomenclature from comments and cost query join#24656
akabiru merged 1 commit into
implementation/comms-934-adjust-workpackageattimerepresenter-with-target_verisonsfrom
chore/drop-primary-version-nomenclature

Conversation

@akabiru

@akabiru akabiru commented Aug 7, 2026

Copy link
Copy Markdown
Member

https://community.openproject.org/wp/COMMS-934

Name the convention literally (the lowest version id) instead; the primary notion is only inferred during the version_id migration period. Reworks #24486

@akabiru
akabiru marked this pull request as ready for review August 7, 2026 09:58
@akabiru akabiru self-assigned this Aug 7, 2026
@akabiru akabiru added this to the 17.8.x milestone Aug 7, 2026
@akabiru akabiru changed the title Drop primary-version nomenclature from comments and cost query join [COMMS-934] Drop primary-version nomenclature from comments and cost query join Aug 7, 2026
Name the convention literally (the lowest version id) instead; the
primary notion is only inferred during the version_id migration period.
@akabiru
akabiru force-pushed the chore/drop-primary-version-nomenclature branch from 7a4b86b to ac6a704 Compare August 7, 2026 10:04
@akabiru
akabiru requested review from a team and brunopagno August 7, 2026 10:07

@brunopagno brunopagno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @akabiru. Thanks a lot. I appreciate the changes.

@akabiru
akabiru merged commit 36d730d into dev Aug 7, 2026
25 checks passed
@akabiru
akabiru deleted the chore/drop-primary-version-nomenclature branch August 7, 2026 14:34
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants