[OP-19885] User cannot update own profile because password confirmation autosaves - #24727
Open
oliverguenther wants to merge 2 commits into
Conversation
oliverguenther
force-pushed
the
bug/op-19885-user-cannot-update-own-profile-because-password-confirmation-autosaves
branch
from
August 13, 2026 06:29
02169cf to
ed5ed06
Compare
bsatarnejad
requested changes
Aug 14, 2026
bsatarnejad
left a comment
bsatarnejad
left a comment
Contributor
There was a problem hiding this comment.
Codewise, It looks good 👍🏼
But it does not fix the. issue that after cancelling the confirmation, the form can be re-submitted, I press the update button, but nothing happens.
bsatarnejad
reviewed
Aug 14, 2026
| // (notably CKEditor-augmented textareas), which can otherwise re-submit via | ||
| // Turbo and bypass the confirmation dialog. | ||
| this.element.addEventListener('submit', this.formListener, { capture: true }); | ||
| document.addEventListener('password-confirmation-dialog:close', this.dialogCloseListener); |
Contributor
There was a problem hiding this comment.
After cancelling, clicking Update profile again does nothing because this close event is not fired and activeDialog stays true.
Member
Author
|
@bsatarnejad I fixed that second regression |
After cancel, Primer/Turbo removes the dialog during its native close handler, which disconnects the dialog Stimulus controller before it can emit password-confirmation-dialog:close. This caused activeDialog to stay true and further submits were ignored.
oliverguenther
force-pushed
the
bug/op-19885-user-cannot-update-own-profile-because-password-confirmation-autosaves
branch
from
August 18, 2026 12:01
5ba4399 to
7f0ed1c
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture the submit event so we can stop other submit handlers (such as the CKEditor component) from firing and submitting the form again in absence of the confirmation
https://community.openproject.org/work_packages/OP-19885