[OP-19965] Fix 500 when initializing an occurrence on a draft recurring meeting template

[jtauschl]

Ticket

https://community.openproject.org/wp/OP-19965

Summary

InitOccurrenceService#draft_template_failure returned only a message with no errors:, which crashed the API layer's ErrorBase.create_and_merge_errors(call.errors) with an ArgumentError ("expected at least one error") when it tried to build a MultipleErrors response from an empty error list. Every recurring meeting's template is in draft state right after creation, so initializing its first occurrence before moving the template out of draft always hit this 500 instead of a clean 422.

Change

Populate the recurring meeting's own errors object before returning failure, matching the errors: shape used elsewhere in this service and across the codebase.

Test plan

• Added a regression spec asserting service_result.errors is non-empty on the draft-template path, alongside the existing message/result expectations
• Verified live against a real 17.7.1 instance: before the fix, init on a fresh recurring meeting's draft template → 500; after the fix → 422 ("The meeting series template is still in draft mode.")

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[jtauschl]

recheck

[Copilot]

Pull request overview

Fixes a recurring-meeting API failure mode where initializing an occurrence on a draft meeting series template produced a 500 due to an empty ServiceResult#errors, ensuring the API layer can consistently build a validation error response (422) instead.

Changes:

• Populate InitOccurrenceService failure results for draft templates with a non-empty errors object (via recurring_meeting.errors).
• Add a regression spec asserting the draft-template failure path returns non-empty service_result.errors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
modules/meeting/app/services/recurring_meetings/init_occurrence_service.rb	Ensures the draft-template failure path returns a failure result with populated errors so API error merging works.
modules/meeting/spec/services/recurring_meetings/init_occurrence_service_spec.rb	Adds regression coverage ensuring the draft-template failure returns non-empty errors suitable for the API layer.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.