[OP-19967] Fix wiki_page_links pagination silently ignoring offset

[jtauschl]

Ticket

https://community.openproject.org/wp/OP-19967

Summary

Both the work-package-scoped and the global GET handlers only passed per_page: into PageLinkCollectionRepresenter.new, never page:. API::Decorators::OffsetPaginatedCollection defaults page to 1 whenever it's not explicitly given, so every request to either endpoint always rendered (and reported) page 1 of the underlying relation, silently ignoring the client's offset query parameter -- total was reported correctly, but offset itself always echoed back 1 and results never advanced past the first page.

Change

Pass params[:offset] through as page: at both call sites.

Test plan

• Added regression request specs on both endpoints asserting the second page returns distinct elements from the first, and that offset is correctly reported
• Verified live against a real 17.7.1 instance: before the fix, offset=2 returned the same elements as offset=1 on both endpoints; after the fix, each returns distinct, correct results independently

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[jtauschl]

recheck

[Copilot]

Pull request overview

This PR fixes API V3 pagination for wiki page links by ensuring the offset query parameter is actually applied when rendering WikiPageLinkCollection responses. It aligns the page-links endpoints with the expected behavior of API::Decorators::OffsetPaginatedCollection, which only paginates correctly when the current page is explicitly provided.

Changes:

• Forward params[:offset] as page: into PageLinkCollectionRepresenter for the work-package-scoped endpoint.
• Forward params[:offset] as page: into PageLinkCollectionRepresenter for the global endpoint.
• Add request-spec regressions asserting offset=2&pageSize=2 returns a distinct second page and reports offset correctly for both endpoints.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
modules/wikis/spec/requests/api/v3/page_links/page_links_api_spec.rb	Adds regression request specs ensuring pagination offset is applied and reported correctly on both endpoints.
modules/wikis/lib/api/v3/page_links/work_package_wiki_page_links_api.rb	Fixes work-package-scoped endpoint by passing params[:offset] as page: to the collection representer.
modules/wikis/lib/api/v3/page_links/page_links_api.rb	Fixes global endpoint by passing params[:offset] as page: to the collection representer.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.