Bump/primer upstream 0.44.1

.changeset/seven-peaches-serve.md

@@ -0,0 +1,5 @@
+---
+"@openproject/primer-view-components": patch
+---
+
+When an error occurs in the SelectPanel, continue throwing the error

.github/workflows/codeql-analysis.yml

@@ -13,7 +13,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/demo-preview-cleanup.yml

@@ -37,7 +37,7 @@ jobs:
           ruby-version: '3.3'
 
       - name: Check out repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       # Delete web app (which will also delete the App Service plan)
       # This will succeed even if the app doesn't exist / has already been deleted

.github/workflows/demo-preview-destroy.yml

@@ -35,7 +35,7 @@ jobs:
           subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
       - name: Check out repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Get preview app info
         run: ./.github/workflows/demo-preview-app-info.sh

.github/workflows/demo-production-deploy.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     environment: production
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Setup Ruby
       uses: ruby/setup-ruby@v1
       with:
@@ -66,7 +66,7 @@ jobs:
     environment: production
     needs: build
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Setup Ruby
       uses: ruby/setup-ruby@v1
       with:

.github/workflows/lint.yml

@@ -13,7 +13,7 @@ jobs:
   markdown:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Get specific changed files
       id: changed-files
       uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
@@ -39,7 +39,7 @@ jobs:
   rubocop:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Get specific changed files
       id: changed-files
       uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
@@ -59,7 +59,7 @@ jobs:
   erblint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Get changed files
       id: changed-files
       uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
@@ -76,7 +76,7 @@ jobs:
   eslint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Get changed files
       id: changed-files
       uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c
@@ -96,7 +96,7 @@ jobs:
   stylelint:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Get changed files
       id: changed-files
       uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c

.github/workflows/preview-deploy.yml

@@ -34,7 +34,7 @@ jobs:
       # to link a PR to a list of environments later.
       url: ${{ env.APP_URL }}
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Install lib deps
       uses: ruby/setup-ruby@v1
       with:

.github/workflows/publish.yml

@@ -6,7 +6,7 @@ jobs:
   publish:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:

.github/workflows/release-checklist.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - uses: jwalton/gh-find-current-pr@v1
         id: findPr
 

.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0

.github/workflows/release_conductor.yml

@@ -0,0 +1,42 @@
+name: Assign Release Conductor
+
+on:
+  pull_request:
+
+jobs:
+  pagerduty:
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.ref == 'changeset-release/main'
+    name: Lookup who is oncall from pagerduty
+    uses: primer/.github/.github/workflows/pagerduty_oncall.yml@v2.2.0
+    with:
+      schedule-id: ${{ vars.PAGERDUTY_RELEASE_CONDUCTOR_SCHEDULE }}
+    secrets:
+      token: ${{ secrets.PAGERDUTY_TOKEN_SHARED }}
+  update-assignee:
+    name: Update assignee and review requests
+    runs-on: ubuntu-latest
+    needs: pagerduty
+    steps:
+      - run: echo ${{ needs.pagerduty.outputs.user }} is the Release conductor
+      - name: Get App Token
+        uses: actions/create-github-app-token@v2
+        id: app-token
+        with:
+          app-id: ${{ vars.PRIMER_APP_ID_SHARED }}
+          owner: primer
+          private-key: ${{ secrets.PRIMER_APP_PRIVATE_KEY_SHARED }}
+      - uses: actions/checkout@v5
+      - name: Get Release PR
+        id: release-pr
+        run: |
+          echo "assignees=$(gh pr view ${{ github.event.number }} --json assignees --jq ".assignees[].login" | tr '\n' ',' | sed 's/,$//')" >> $GITHUB_OUTPUT
+          echo "reviews=$(gh pr view ${{ github.event.number }} --json reviewRequests  --jq ".reviewRequests[].login" | tr '\n' ',' | sed 's/,$//')" >> $GITHUB_OUTPUT
+        env:
+          GH_TOKEN: ${{ steps.app-token.outputs.token }}
+      - name: Reset Assignees & Reviewers
+        if: ${{ ! contains( steps.release-pr.outputs.assignees, needs.pagerduty.outputs.user ) }}
+        run: |
+          gh pr edit ${{ github.event.number }} --remove-reviewer "${{ steps.release-pr.outputs.reviews }}" --remove-assignee "${{ steps.release-pr.outputs.assignees }}"
+          gh pr edit ${{ github.event.number }} --add-reviewer ${{ needs.pagerduty.outputs.user }} --add-assignee ${{ needs.pagerduty.outputs.user }}
+        env:
+          GH_TOKEN: ${{ steps.app-token.outputs.token }}

.github/workflows/static-files.yml

@@ -11,7 +11,7 @@ jobs:
     steps:
       # Unfortunately we can't use the primer GitHub App and camertron/github-app-installation-auth-action
       # because branch protection rules cannot be bypassed by Apps.
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           token: ${{ secrets.GPR_AUTH_TOKEN_SHARED }}
       - uses: ruby/setup-ruby@v1

.github/workflows/test.yml

@@ -31,7 +31,7 @@ jobs:
         - runner=16cpu-linux-x64
         - run-id=${{ github.run_id }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.4'
@@ -69,7 +69,7 @@ jobs:
           - rails_version: 'main'
             ruby_version: '3.4'
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -115,7 +115,7 @@ jobs:
           - rails_version: 'main'
             ruby_version: '3.4'
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -157,7 +157,7 @@ jobs:
           - rails_version: 'main'
             ruby_version: '3.4'
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -180,7 +180,7 @@ jobs:
     name: System (Chrome)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.2'
@@ -203,7 +203,7 @@ jobs:
     name: System (Firefox)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.2'
@@ -228,7 +228,7 @@ jobs:
     timeout-minutes: 20
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           ref: ${{ github.event.pull_request.head.ref }}
           repository: ${{ github.event.pull_request.head.repo.full_name }}
@@ -310,7 +310,7 @@ jobs:
         - run-id=${{ github.run_id }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:

.github/workflows/triage.yml

@@ -41,7 +41,7 @@ jobs:
       - if: ${{ (github.event_name != 'merge_group' && !contains(github.event.pull_request.labels.*.name, 'skip changeset')) != true }}
         run: echo "passed"; exit 0;
       - if: ${{ (github.event_name != 'merge_group' && !contains(github.event.pull_request.labels.*.name, 'skip changeset')) == true }}
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           ref: ${{ github.event.pull_request.head.sha }}
       - if: ${{ (github.event_name != 'merge_group' && !contains(github.event.pull_request.labels.*.name, 'skip changeset')) == true }}

Gemfile

@@ -68,7 +68,7 @@ group :development do
   gem "rubocop-performance"
   gem "rubocop-rails"
   gem "rubocop-rails-accessibility", "~> 1.0"
-  gem "selenium-webdriver", "~> 4.34"
+  gem "selenium-webdriver", "~> 4.35"
   gem "simplecov", "~> 0.22.0"
   gem "simplecov-console", "~> 0.9.4"
   gem "sprockets"

Gemfile.lock

@@ -162,7 +162,7 @@ GEM
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.4.0)
+    prism (1.5.1)
     psych (5.2.6)
       date
       stringio
@@ -207,20 +207,20 @@ GEM
       erb
       psych (>= 4.0.0)
     redcarpet (3.6.1)
-    regexp_parser (2.11.0)
+    regexp_parser (2.11.3)
     reline (0.6.2)
       io-console (~> 0.5)
     rexml (3.4.1)
-    rouge (4.5.2)
-    rubocop (1.76.1)
+    rouge (4.6.0)
+    rubocop (1.80.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.45.0, < 2.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.46.0)
@@ -244,13 +244,13 @@ GEM
       rubocop (>= 1.0.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    rubyzip (2.4.1)
+    rubyzip (3.0.1)
     securerandom (0.4.1)
-    selenium-webdriver (4.34.0)
+    selenium-webdriver (4.35.0)
       base64 (~> 0.2)
       logger (~> 1.4)
       rexml (~> 3.2, >= 3.2.5)
-      rubyzip (>= 1.2.2, < 3.0)
+      rubyzip (>= 1.2.2, < 4.0)
       websocket (~> 1.0)
     simplecov (0.22.0)
       docile (~> 1.1)
@@ -279,9 +279,9 @@ GEM
     timecop (0.9.10)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
     uri (1.0.3)
     useragent (0.16.11)
     view_component (4.0.1)
@@ -343,7 +343,7 @@ DEPENDENCIES
   rubocop-performance
   rubocop-rails
   rubocop-rails-accessibility (~> 1.0)
-  selenium-webdriver (~> 4.34)
+  selenium-webdriver (~> 4.35)
   simplecov (~> 0.22.0)
   simplecov-console (~> 0.9.4)
   sourcemap (~> 0.1)

app/components/primer/alpha/select_panel_element.ts

@@ -554,10 +554,8 @@ export class SelectPanelElement extends HTMLElement {
         // check if the errorElement is visible in the dom
         if (errorElement && !errorElement.hasAttribute('hidden')) {
           this.liveRegion.announceFromElement(errorElement, {politeness: 'assertive'})
-          return
         }
-
-        break
+        throw new Error((event as CustomEvent).detail.error)
       }
     }
   }

demo/Gemfile

@@ -37,15 +37,15 @@ gem "puma", "~> 6.6.1"
 gem "bootsnap", ">= 1.4.2", require: false
 
 gem "openproject-primer_view_components", path: "../"
-gem "view_component", "4.0.0.rc5"
-gem "lookbook", "~> 2.3.12" unless rails_version.to_f < 7
+gem "view_component", "4.0.2"
+gem "lookbook", "~> 2.3.13" unless rails_version.to_f < 7
 
 gem "vite_rails", "~> 3.0"
 gem "cssbundling-rails", "~> 1.4"
 
 group :development do
   # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
-  gem "spring", "~> 4.2"
+  gem "spring", "~> 4.4"
   gem "spring-watcher-listen", "~> 2.1"
   gem "hotwire-livereload", "~> 2.0"