Skip to content

[67494] Replace Angular loading spinner with Primer loadind spinner in Feedback Dialogs #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDinger merged 1 commit into from
Sep 17, 2025
Merged

[67494] Replace Angular loading spinner with Primer loadind spinner in Feedback Dialogs #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-parts-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/primer-view-components': patch
---

Change loading spinner for FeedbackMessage and FeedbackDialog
1 change: 0 additions & 1 deletion app/assets/images/loading_indicator.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion app/components/primer/open_project/feedback_message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def initialize(icon_arguments: {}, loading: false, **system_arguments)

def before_render
if @loading
@blankslate.with_visual_image(src: asset_path("loading_indicator.svg"), alt: I18n.t(:label_loading))
@blankslate.with_visual_spinner(size: :large)
elsif @icon_arguments[:icon] != :none
@blankslate.with_visual_icon(size: :medium, **@icon_arguments)
end
Expand Down
2 changes: 1 addition & 1 deletion test/components/primer/open_project/feedback_dialog_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_renders_loading_spinner

assert_selector("dialog.FeedbackDialog") do
assert_selector(".Overlay-body h2", text: "Ups, something went wrong")
assert_selector("img.blankslate-image[src^='/assets/loading_indicator']")
assert_selector("svg.blankslate-image")
end
end
end
2 changes: 1 addition & 1 deletion test/components/primer/open_project/feedback_message_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_renders_loading_spinner
end

assert_selector("h2", text: "Ups, something went wrong")
assert_selector("img.blankslate-image[src^='/assets/loading_indicator']")
assert_selector("svg.blankslate-image")
end

def test_renders_secondary_action
Expand Down
Loading