[67542] Allow single selection variant for the tree view - #360
Merged
HDinger merged 5 commits intoSep 30, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: c9acf8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
marked this pull request as draft
September 26, 2025 13:18
|
HDinger
force-pushed
the
feature/67542-allow-single-selection-variant-for-the-tree-view
branch
6 times, most recently
from
September 30, 2025 06:26
0a6743d to
74c215e
Compare
HDinger
marked this pull request as ready for review
September 30, 2025 07:06
Member
|
There is quite a delay when toggling another item, the previous checkmark is removed quite "sluggishly". Not a big deal, just something I noticed when using the component |
oliverguenther
approved these changes
Sep 30, 2025
HDinger
force-pushed
the
feature/67542-allow-single-selection-variant-for-the-tree-view
branch
from
September 30, 2025 10:47
92d02ca to
346b1ee
Compare
1 task
HDinger
deleted the
feature/67542-allow-single-selection-variant-for-the-tree-view
branch
September 30, 2025 11:27
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Support
:singleasselect_variantfor the TreeViewScreenshots
Integration
No
List the issues that this change affects.
https://community.openproject.org/wp/67542
Risk Assessment
What approach did you choose and why?
I tried to copy the approach of the SelectPanel, which is showingan arrow to indicate the selection. Toggling the visibility is based on the
aria-checkedstate.By using
aria-checkedas the base, we remain also consistent with our implementation forselect_variant: :multiplewhich leads to less code being needed.Merge checklist