Skip to content

Update SubMenuItem to delegate items call to SubMenu #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDinger merged 1 commit into from
Oct 1, 2025
Merged

Update SubMenuItem to delegate items call to SubMenu #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-clowns-visit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/primer-view-components': patch
---

Delegate the items call to SubMenu of ActionMenu component
2 changes: 2 additions & 0 deletions app/components/primer/alpha/action_menu/sub_menu_item.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ class ActionMenu
# This component is part of <%= link_to_component(Primer::Alpha::ActionMenu) %> and should not be
# used as a standalone component.
class SubMenuItem < ::Primer::Alpha::ActionList::Item
delegate :items, to: :@sub_menu

def initialize(content_arguments: {}, form_arguments: {}, **system_arguments)
# We extract form_arguments from system_arguments here to avoid passing them to the
# ActionList::Item base class or to the SubMenu instance. Doing so prevents a form
Expand Down
Loading