Skip to content

[68906] Truncate breadcrumb in PageHeader - #380

Merged
HDinger merged 3 commits into
mainfrom
feature/68906-truncate-breadcrumb-in-pageheader
Nov 13, 2025
Merged

[68906] Truncate breadcrumb in PageHeader#380
HDinger merged 3 commits into
mainfrom
feature/68906-truncate-breadcrumb-in-pageheader

Conversation

@HDinger

@HDinger HDinger commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator

What are you trying to accomplish?

Truncate breadcrumb elements in PageHeader

Screenshots

Bildschirmfoto 2025-11-11 um 10 18 57

List the issues that this change affects.

https://community.openproject.org/wp/68906

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

What approach did you choose and why?

Making use of existing Primer functionality: https://qa.openproject-edge.com/lookbook/inspect/primer/beta/breadcrumbs/with_beta_truncate

@changeset-bot

changeset-bot Bot commented Nov 11, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cdfa08f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HDinger
HDinger force-pushed the feature/68906-truncate-breadcrumb-in-pageheader branch 2 times, most recently from 878ec4d to d8e5949 Compare November 11, 2025 09:22
@github-actions

github-actions Bot commented Nov 11, 2025

Copy link
Copy Markdown

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@HDinger
HDinger force-pushed the feature/68906-truncate-breadcrumb-in-pageheader branch from 0a347cb to 6305c8d Compare November 11, 2025 12:25
assert_selector(".PageHeader-breadcrumbs")
assert_selector(".PageHeader-parentLink")

assert_selector(".breadcrumb-item a[href='/baz'] .Truncate > .Truncate-text[style='max-width: 135px;']",

@bsatarnejad bsatarnejad Nov 13, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline style should be max-width: 200px; because of BREADCRUMB_TRUNCATE_AT = 200
Screenshot 2025-11-13 at 13 32 53

@HDinger
HDinger merged commit a7a141e into main Nov 13, 2025
22 of 25 checks passed
@HDinger
HDinger deleted the feature/68906-truncate-breadcrumb-in-pageheader branch November 13, 2025 13:22
@openprojectci openprojectci mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants