Skip to content

[67724] Use line-height instead of height for the page header title styles - #381

Merged
bsatarnejad merged 2 commits into
mainfrom
67724-fix-page-header-title-collpsed-with-a-long-text
Nov 13, 2025
Merged

[67724] Use line-height instead of height for the page header title styles#381
bsatarnejad merged 2 commits into
mainfrom
67724-fix-page-header-title-collpsed-with-a-long-text

Conversation

@bsatarnejad

@bsatarnejad bsatarnejad commented Nov 12, 2025

Copy link
Copy Markdown

What are you trying to accomplish?

When a page header is displayed without a breadcrumb and has a long title and tab navigation, the title is collapsed into the tab navigation. Instead of setting the height of the title, we need to set the line height for it.

Screenshots

Before:

Brocken page header

After:
Page header title with line height set

@changeset-bot

changeset-bot Bot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 03575a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HDinger HDinger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

@bsatarnejad
bsatarnejad merged commit da5904a into main Nov 13, 2025
17 of 20 checks passed
@openprojectci openprojectci mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants