Bump/primer upstream by myabc · Pull Request #393 · opf/primer_view_components

myabc · 2025-12-12T14:00:08Z

No description provided.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Jones <tylerjdev@github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… and configurability (primer#3784)

…cies group (primer#3756) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…rimer#3762) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jon Rohan <rohan@github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hector Garcia <hectahertz@github.com> Co-authored-by: Jon Rohan <rohan@github.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

changeset-bot · 2025-12-12T14:00:12Z

⚠️ No Changeset found

Latest commit: 58976e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

Pull request overview

This PR merges upstream dependency updates from GitHub's Primer ViewComponents repository. The changes include bumping several npm development dependencies (markdownlint-cli2, related markdown processing libraries, js-yaml, and katex) and Ruby gems (nio4r and puma). Additionally, the monolithic test.yml workflow has been split into separate workflow files for better organization and the test matrix has been streamlined by removing the Rails "main" branch test configuration.

Key changes:

Updated npm dependencies: markdownlint-cli2 (0.18.1 → 0.19.1), js-yaml (4.1.0 → 4.1.1), katex (0.16.22 → 0.16.27), and related packages
Updated Ruby gems: puma (7.0.4 → 7.1.0) and nio4r (2.7.4 → 2.7.5)
Refactored CI workflows: Split the monolithic test.yml into separate workflow files (test-accessibility.yml, test-components.yml, test-lib.yml, test-performance.yml, test-selectors.yml, test-system.yml, test-visual.yml)
Simplified test matrix by removing Rails "main" branch testing and adjusting runner configurations

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
package.json	Bumped markdownlint-cli2 from 0.18.1 to 0.19.1
package-lock.json	Updated lockfile with new versions of markdownlint-cli2 and its dependencies (@sindresorhus/merge-streams, decode-named-character-reference, js-yaml, katex, markdownlint, markdownlint-cli2-formatter-default, globby)
Gemfile	Updated puma version from ~> 7.0.4 to ~> 7.1.0
Gemfile.lock	Updated lockfile reflecting puma 7.1.0 and nio4r 2.7.5
.github/workflows/test.yml	Deleted monolithic test workflow file (308 lines removed)
.github/workflows/test-visual.yml	New workflow file for visual and semantic markup regression tests (extracted from test.yml)
.github/workflows/test-system.yml	New workflow file for system tests with Chrome (extracted from test.yml, Firefox commented out)
.github/workflows/test-selectors.yml	New workflow file for CSS coverage tests (extracted from test.yml)
.github/workflows/test-performance.yml	New workflow file for performance tests (extracted from test.yml)
.github/workflows/test-lib.yml	New workflow file for lib tests (extracted from test.yml)
.github/workflows/test-components.yml	New workflow file for component tests (extracted from test.yml)
.github/workflows/test-accessibility.yml	New workflow file for accessibility tests (extracted from test.yml)
.github/version-matrix.json	Removed "main" Rails version from test matrix, reformatted JSON structure

Copilot · 2025-12-17T13:11:35Z

  {
+    "label": "latest",
    "rails_version": "latest",
-    "ruby_version": "3.4",
-    "label": "latest"
-  },
-  {
-    "rails_version": "main",
-    "ruby_version": "3.4",
-    "label": "main"
+    "ruby_version": "3.4"
  }


The removal of the "main" Rails version from the test matrix means the codebase will no longer be tested against the Rails main branch. This could lead to compatibility issues with future Rails releases going undetected until after Rails has been released.

The Gemfile still contains support for RAILS_VERSION="main" (lines 17-24), which suggests this test matrix entry should be retained to ensure the code works with Rails edge/main branch. Consider whether this removal is intentional or if the "main" test matrix entry should be restored.

Copilot · 2025-12-17T13:11:35Z

+  group: test-accessibility-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:


The FERRUM_PROCESS_TIMEOUT environment variable was reduced from 45 seconds (in the old test.yml) to 30 seconds across all the new workflow files. This is not set in this particular workflow file, but is set in test-visual.yml, test-system.yml, test-performance.yml, test-lib.yml, and test-components.yml.

However, the test-accessibility.yml workflow runs accessibility tests that may benefit from the timeout setting as well. Consider whether this workflow should also include the FERRUM_PROCESS_TIMEOUT environment variable for consistency, or whether it's intentionally omitted because accessibility tests don't use Ferrum.

Copilot · 2025-12-17T13:11:36Z

+  group: test-selectors-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:


Similar to test-accessibility.yml, this workflow does not include the FERRUM_PROCESS_TIMEOUT environment variable that is set in the other test workflows (test-visual.yml, test-system.yml, test-performance.yml, test-lib.yml, and test-components.yml). Consider whether this is intentional or if it should be added for consistency.

primer Bot and others added 15 commits December 3, 2025 19:32

Release Tracking (primer#3782)

b2e4904

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Bump glob (primer#3774)

5a4b308

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump actions/upload-artifact from 4 to 5 (primer#3754)

21d3b07

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump js-yaml and markdownlint-cli2 (primer#3781)

a1bfa43

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump octicons from 19.18.0 to 19.19.0 in /demo (primer#3737)

388548f

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump rack from 3.2.1 to 3.2.3 (primer#3729)

1eda449

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Jones <tylerjdev@github.com>

Bump puma from 7.0.4 to 7.1.0 (primer#3742)

cc60061

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Extract the test.yml workflow into separate workflows for easy reruns…

5f384bc

… and configurability (primer#3784)

Bump @primer/behaviors from 1.8.3 to 1.8.4 in the production-dependen…

ff04ce9

…cies group (primer#3756) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump rake from 13.3.0 to 13.3.1 in the production-dependencies group (p…

643693a

…rimer#3762) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump rubocop from 1.80.2 to 1.81.1 (primer#3707)

69a892a

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jon Rohan <rohan@github.com>

Bump @primer/stylelint-config from 13.3.2 to 13.4.1 (primer#3795)

d52ddf7

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge branch 'bump/primer-upstream-ref' into bump/primer-upstream

43ed22b

Commit generated static/classes.json

ba4193c

Generating static files

58976e4

myabc added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Dec 12, 2025

myabc marked this pull request as ready for review December 17, 2025 13:08

Copilot AI review requested due to automatic review settings December 17, 2025 13:08

myabc merged commit e021308 into main Dec 17, 2025
34 of 37 checks passed

Copilot started reviewing on behalf of myabc December 17, 2025 13:09 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Navigation Menu

Uh oh!

Bump/primer upstream - #393

Bump/primer upstream#393
myabc merged 16 commits into
mainfrom
bump/primer-upstream

myabc commented Dec 12, 2025

Uh oh!

changeset-bot Bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

myabc commented Dec 12, 2025

Uh oh!

changeset-bot Bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Dec 12, 2025 •

edited

Loading