Bump/primer upstream

.changeset/fix-dropdown-caret-borders.md

@@ -0,0 +1,5 @@
+---
+"@openproject/primer-view-components": patch
+---
+
+Fix Dropdown component caret position in CSS styles for clean borders

.github/workflows/demo-production-deploy.yml

@@ -80,7 +80,7 @@ jobs:
       with:
         ruby-version: '3.4'
         bundler-cache: true
-    - uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
+    - uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
       with:
         path: demo/gemfiles/vendor/bundle
         key: gems-build-kuby-main-ruby-3.4.x-${{ hashFiles('demo/gemfiles/kuby.gemfile.lock') }}

.github/workflows/lint.yml

@@ -22,7 +22,7 @@ jobs:
         persist-credentials: false
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
+      uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96
       with:
         files: |
           docs/**/*.md
@@ -54,7 +54,7 @@ jobs:
         persist-credentials: false
     - name: Get specific changed files
       id: changed-files
-      uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
+      uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96
       with:
         files: |
           app/**/*.rb
@@ -79,7 +79,7 @@ jobs:
         persist-credentials: false
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
+      uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96
       with:
         files: |
           app/components/**/*.erb
@@ -101,7 +101,7 @@ jobs:
         persist-credentials: false
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
+      uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96
       with:
         files: |
           app/components/**/*.ts
@@ -128,7 +128,7 @@ jobs:
         persist-credentials: false
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
+      uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96
       with:
         files: |
           app/components/**/*.pcss

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_e/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_e/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_ne/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_ne/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_s/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_s/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_se/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_se/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_sw/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_sw/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_w/aria-snapshot--after-interaction.yml

@@ -0,0 +1,6 @@
+- group:
+  - button "Close" [expanded]: Dropdown
+  - menu:
+    - menuitem "Item 1"
+    - menuitem "Item 2"
+    - menuitem "Item 3"

.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/dropdown/direction_w/aria-snapshot.yml

@@ -0,0 +1,2 @@
+- group:
+  - button "Open": Dropdown

Gemfile

@@ -31,7 +31,7 @@ else
 end
 
 # Use Puma as the app server
-gem "puma", "~> 7.2.0"
+gem "puma", "~> 8.0.1"
 
 # Reduces boot times through caching; required in config/boot.rb
 gem "bootsnap", ">= 1.4.2", require: false
@@ -40,7 +40,7 @@ gem "lookbook", "~> 2.3.14"
 if ENV["VIEW_COMPONENT_PATH"]
   gem "view_component", path: ENV["VIEW_COMPONENT_PATH"]
 else
-  gem "view_component", "4.6.0"
+  gem "view_component", "4.9.0"
 end
 
 gem "kramdown", "~> 2.5"
@@ -78,5 +78,5 @@ group :development do
   gem "sprockets-rails"
   gem "thor"
   gem "timecop"
-  gem "yard", "~> 0.9.38"
+  gem "yard", "~> 0.9.43"
 end

Gemfile.lock

@@ -187,7 +187,7 @@ GEM
       date
       stringio
     public_suffix (7.0.5)
-    puma (7.2.0)
+    puma (8.0.1)
       nio4r (~> 2.0)
     racc (1.8.1)
     rack (3.2.6)
@@ -306,7 +306,7 @@ GEM
     unicode-emoji (4.2.0)
     uri (1.1.1)
     useragent (0.16.11)
-    view_component (4.6.0)
+    view_component (4.9.0)
       actionview (>= 7.1.0)
       activesupport (>= 7.1.0)
       concurrent-ruby (~> 1)
@@ -365,7 +365,7 @@ DEPENDENCIES
   minitest (~> 5.0)
   mocha
   openproject-primer_view_components!
-  puma (~> 7.2.0)
+  puma (~> 8.0.1)
   rack-cors
   railties (= 8.0.2)
   rake (~> 13.3)
@@ -382,10 +382,10 @@ DEPENDENCIES
   sprockets-rails
   thor
   timecop
-  view_component (= 4.6.0)
+  view_component (= 4.9.0)
   vite_rails (~> 3.0)
   webmock
-  yard (~> 0.9.38)
+  yard (~> 0.9.43)
 
 BUNDLED WITH
    2.5.5

app/components/primer/alpha/dropdown.pcss

@@ -26,17 +26,15 @@
   left: 0;
   z-index: 100;
   width: 160px;
-  /* stylelint-disable-next-line primer/spacing */
   padding-top: var(--control-small-paddingBlock);
-  /* stylelint-disable-next-line primer/spacing */
   padding-bottom: var(--control-small-paddingBlock);
   margin-top: var(--base-size-2);
   list-style: none;
   background-color: var(--overlay-bgColor);
   background-clip: padding-box;
   border: var(--borderWidth-thin) solid var(--borderColor-default);
   border-radius: var(--borderRadius-medium);
-  box-shadow: var(--shadow-floating-legacy, var(--color-shadow-large));
+  box-shadow: var(--shadow-floating-small);
 
   &::before,
   &::after {
@@ -70,7 +68,6 @@
   width: auto;
 
   & .dropdown-item {
-    /* stylelint-disable-next-line primer/spacing */
     padding: var(--control-small-paddingBlock) var(--control-medium-paddingInline-spacious);
     overflow: visible;
     text-overflow: inherit;
@@ -80,7 +77,6 @@
 /* Dropdown items (can be links or buttons) */
 .dropdown-item {
   display: block;
-  /* stylelint-disable-next-line primer/spacing */
   padding: var(--control-small-paddingBlock) var(--control-medium-paddingInline-condensed) var(--control-small-paddingBlock) var(--control-medium-paddingInline-spacious);
   overflow: hidden;
   color: var(--fgColor-default);
@@ -123,13 +119,11 @@
 .dropdown-divider {
   display: block;
   height: 0;
-  /* stylelint-disable-next-line primer/spacing */
   margin: var(--stack-gap-condensed) 0;
   border-top: var(--borderWidth-thin) solid var(--borderColor-default);
 }
 
 .dropdown-header {
-  /* stylelint-disable-next-line primer/spacing */
   padding: var(--control-small-paddingBlock) var(--control-medium-paddingInline-spacious);
   font-size: var(--text-body-size-small);
   color: var(--fgColor-muted);
@@ -163,7 +157,8 @@
   }
 
   &::after {
-    top: var(--base-size-12);
+    /* stylelint-disable-next-line primer/spacing */
+    top: calc(var(--base-size-12) - var(--borderWidth-thin));
     /* stylelint-disable-next-line primer/spacing */
     right: -14px;
     left: auto;
@@ -190,7 +185,8 @@
   }
 
   &::after {
-    top: var(--base-size-12);
+    /* stylelint-disable-next-line primer/spacing */
+    top: calc(var(--base-size-12) - var(--borderWidth-thin));
     /* stylelint-disable-next-line primer/spacing */
     left: -14px;
     border-color: transparent;
@@ -228,7 +224,7 @@
     /* stylelint-disable-next-line primer/spacing */
     bottom: -7px;
     /* stylelint-disable-next-line primer/spacing */
-    left: 10px;
+    left: calc(var(--base-size-8) + var(--borderWidth-thin));
     /* stylelint-disable-next-line primer/borders, primer/colors */
     border-top: 7px solid var(--overlay-bgColor);
     /* stylelint-disable-next-line primer/borders */
@@ -274,7 +270,7 @@
     /* stylelint-disable-next-line primer/spacing */
     top: -14px;
     /* stylelint-disable-next-line primer/spacing */
-    right: 10px;
+    right: calc(var(--base-size-8) + var(--borderWidth-thin));
     left: auto;
   }
 }
@@ -290,6 +286,6 @@
     /* stylelint-disable-next-line primer/spacing */
     top: -14px;
     /* stylelint-disable-next-line primer/spacing */
-    left: 10px;
+    left: calc(var(--base-size-8) + var(--borderWidth-thin));
   }
 }

demo/Gemfile

@@ -4,7 +4,7 @@ source "https://rubygems.org"
 
 rails_version = (ENV["RAILS_VERSION"] || "7.2.2.1").to_s
 
-gem "rake", "~> 13.3"
+gem "rake", "~> 13.4"
 gem "rack-cors"
 gem "sprockets"
 gem "sprockets-rails"
@@ -31,13 +31,13 @@ end
 eval_gemfile "gemfiles/kuby.gemfile"
 
 # Use Puma as the app server
-gem "puma", "~> 7.2.0"
+gem "puma", "~> 8.0.1"
 
 # Reduces boot times through caching; required in config/boot.rb
 gem "bootsnap", ">= 1.4.2", require: false
 
 gem "openproject-primer_view_components", path: "../"
-gem "view_component", "4.6.0"
+gem "view_component", "4.9.0"
 gem "lookbook", "~> 2.3.14" unless rails_version.to_f < 7
 
 gem "vite_rails", "~> 3.0"

demo/Gemfile.lock

@@ -280,7 +280,7 @@ GEM
       date
       stringio
     public_suffix (7.0.2)
-    puma (7.2.0)
+    puma (8.0.1)
       nio4r (~> 2.0)
     racc (1.8.1)
     rack (3.1.21)
@@ -362,7 +362,7 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     useragent (0.16.11)
-    view_component (4.6.0)
+    view_component (4.9.0)
       actionview (>= 7.1.0)
       activesupport (>= 7.1.0)
       concurrent-ruby (~> 1)
@@ -411,17 +411,17 @@ DEPENDENCIES
   lookbook (~> 2.3.14)
   openproject-primer_view_components!
   pry-byebug
-  puma (~> 7.2.0)
+  puma (~> 8.0.1)
   rack-cors
   railties (= 7.2.2.1)
-  rake (~> 13.3)
+  rake (~> 13.4)
   spring (~> 4.4)
   spring-watcher-listen (~> 2.1)
   sprockets
   sprockets-rails
   stimulus-rails
   turbo-rails
-  view_component (= 4.6.0)
+  view_component (= 4.9.0)
   vite_rails (~> 3.0)
 
 BUNDLED WITH