[75258] Hide pagination buttons when they are disabled

[bsatarnejad]

What are you trying to accomplish?

• Hide Previous and Next pagination links when there is no page to navigate to
• Remove disabled Previous/Next rendering logic from the pagination component
• Update pagination tests to cover first page, last page, and single-page behavior

Screenshots

Before:

After:

Closes https://community.openproject.org/wp/75258

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

[changeset-bot]

🦋 Changeset detected

Latest commit: 876c8ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@openproject/primer-view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Uh oh! @bsatarnejad, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

• Images should have meaningful alternative text (alt text) at line 8
• Images should have meaningful alternative text (alt text) at line 11

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

[HDinger]

I know that it was not specified but what do you think about hiding the Pagination completely when there is only one page? Currently there is only one button shown which basically does nothing, so there is no real value in it imho.

[HDinger]

I know that it was not specified but what do you think about hiding the Pagination completely when there is only one page? Currently there is only one button shown which basically does nothing, so there is no real value in it imho.

Primer seems to recommend that as well: https://primer.style/product/components/pagination/guidelines/#best-practices

[HDinger]

Nitpick: I think this is only part of the truth.. The bit about hiding buttons when you are at the edge of the pagination is missing.

[github-actions]

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences