Skip to content

Remove some constantly failing previews from the playwright testing #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDinger merged 2 commits into from
Jul 2, 2026
Merged

Remove some constantly failing previews from the playwright testing #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b280409
Remove some constantly failing previews from the playwright testing
HDinger Jul 2, 2026
19295cc
Generating static files
openprojectci Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions previews/primer/alpha/segmented_control_preview.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def full_width_medium(hide_labels: false)
# @!endgroup

# @!group Icons and text
# @label Size small
# @snapshot
def icons_and_text_small
render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :small)) do |component|
Expand All @@ -69,7 +68,6 @@ def icons_and_text_small
end

# @label Size medium
# @snapshot
def icons_and_text_medium
render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :medium)) do |component|
component.with_item(label: "Preview", icon: :eye, selected: true)
Expand All @@ -81,7 +79,6 @@ def icons_and_text_medium

# @!group Trailing Label
# @label Size small
# @snapshot
def trailing_label_width_small
render(Primer::Alpha::SegmentedControl.new("aria-label": "Billing duration", size: :small)) do |component|
component.with_item(label: "Monthly")
Expand All @@ -92,7 +89,6 @@ def trailing_label_width_small
end

# @label Size medium
# @snapshot
def trailing_label_width_medium
render(Primer::Alpha::SegmentedControl.new("aria-label": "Billing duration", size: :medium)) do |component|
component.with_item(label: "Monthly")
Expand Down
2 changes: 1 addition & 1 deletion previews/primer/open_project/filterable_tree_view_preview.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def playground(expanded: true, select_variant: :multiple, show_checkbox: true, s

# @label Default
#
# @snapshot interactive
# @snapshot
# @param expanded [Boolean] toggle
def default(expanded: true)
render_with_template(locals: {
Expand Down
8 changes: 4 additions & 4 deletions static/info_arch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7301,7 +7301,7 @@
{
"preview_path": "primer/alpha/segmented_control/icons_and_text_medium",
"name": "icons_and_text_medium",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand All @@ -7314,7 +7314,7 @@
{
"preview_path": "primer/alpha/segmented_control/trailing_label_width_small",
"name": "trailing_label_width_small",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand All @@ -7327,7 +7327,7 @@
{
"preview_path": "primer/alpha/segmented_control/trailing_label_width_medium",
"name": "trailing_label_width_medium",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand Down Expand Up @@ -20443,7 +20443,7 @@
{
"preview_path": "primer/open_project/filterable_tree_view/default",
"name": "default",
"snapshot": "interactive",
"snapshot": "true",
"skip_rules": {
"wont_fix": [
"region"
Expand Down
8 changes: 4 additions & 4 deletions static/previews.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4440,7 +4440,7 @@
{
"preview_path": "primer/open_project/filterable_tree_view/default",
"name": "default",
"snapshot": "interactive",
"snapshot": "true",
"skip_rules": {
"wont_fix": [
"region"
Expand Down Expand Up @@ -7203,7 +7203,7 @@
{
"preview_path": "primer/alpha/segmented_control/icons_and_text_medium",
"name": "icons_and_text_medium",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand All @@ -7216,7 +7216,7 @@
{
"preview_path": "primer/alpha/segmented_control/trailing_label_width_small",
"name": "trailing_label_width_small",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand All @@ -7229,7 +7229,7 @@
{
"preview_path": "primer/alpha/segmented_control/trailing_label_width_medium",
"name": "trailing_label_width_medium",
"snapshot": "true",
"snapshot": "false",
"skip_rules": {
"wont_fix": [
"region"
Expand Down
Loading