Skip to content

Bump/primer upstream - #497

Merged
myabc merged 33 commits into
mainfrom
bump/primer-upstream
Jul 9, 2026
Merged

Bump/primer upstream#497
myabc merged 33 commits into
mainfrom
bump/primer-upstream

Conversation

@myabc

@myabc myabc commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

primer Bot and others added 28 commits May 11, 2026 15:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…icit body classes (primer#4069)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Jon Rohan <rohan@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…encies group (primer#4073)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Jones <tylerjdev@github.com>
… across 1 directory (primer#4077)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ross 1 directory (primer#4075)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: LiuLiu <liuliu-dev@github.com>
…ates (primer#4088)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jon Rohan <rohan@github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
# Conflicts:
#	.github/workflows/release-checklist.yml
#	.github/workflows/triage.yml
#	demo/Gemfile
#	demo/package-lock.json
#	package-lock.json
#	package.json
@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 60a9902

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myabc
myabc marked this pull request as ready for review July 9, 2026 16:05
Copilot AI review requested due to automatic review settings July 9, 2026 16:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sync-related update to this OpenProject fork of Primer ViewComponents, pulling upstream dependency/tooling changes and aligning Dialog scroll-lock behavior and render_in signatures with upstream expectations.

Changes:

  • Updated Dialog scroll-lock implementation from :has(...) selectors to explicit body classes managed by dialog_helper.ts, plus added/adjusted tests and selector ignore-lists.
  • Bumped multiple Ruby and npm dependencies (including cssnano 8) and updated GitHub Actions workflows to use Node 24.
  • Updated several render_in overrides to accept keyword arguments.

Reviewed changes

Copilot reviewed 26 out of 30 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/css/component_specific_selectors_test.rb Ignores new Dialog-related body classes in selector coverage test.
test/components/primer/alpha/dialog_test.rb Adds coverage for default Overlay--disableScroll behavior and opt-out.
package.json Bumps JS deps (clipboard-copy-element, cssnano).
package-lock.json Lockfile refresh reflecting upgraded JS dependency graph and new engine requirements.
lib/primer/form_components.rb Updates render_in signature to accept keyword args.
Gemfile.lock Updates locked Ruby gem versions (e.g., puma, rack-proxy, vite_rails, yard).
Gemfile Updates gem constraints (puma, vite_rails, yard).
demo/package.json Bumps demo dependencies (Primer CSS/primitives, vite tooling).
demo/package-lock.json Lockfile refresh for demo dependency upgrades.
demo/Gemfile.lock Updates demo’s locked gem versions (e.g., puma, rack-proxy, spring, vite_rails).
demo/Gemfile Updates demo gem constraints (puma, vite_rails, spring).
app/lib/primer/forms/toggle_switch_form.rb Updates render_in signature to accept keyword args.
app/lib/primer/forms/acts_as_component.rb Updates render_in signature to accept keyword args.
app/components/primer/dialog_helper.ts Adds body class management for modal/open dialogs to support CSS scroll-lock without :has.
app/components/primer/beta/button_group.rb Updates render_in signature for MenuButton helper.
app/components/primer/alpha/tree_view/visual.rb Updates render_in signature to accept keyword args.
app/components/primer/alpha/tree_view/sub_tree_node.rb Updates render_in signature to accept keyword args.
app/components/primer/alpha/dialog.pcss Switches scroll-lock selectors to body.has-modal* classes.
.github/workflows/test-visual.yml Updates CI Node version to 24.
.github/workflows/test-system.yml Updates CI Node version to 24.
.github/workflows/test-selectors.yml Updates CI Node version to 24.
.github/workflows/test-lib.yml Updates CI Node version to 24.
.github/workflows/test-components.yml Updates CI Node version to 24.
.github/workflows/test-accessibility.yml Updates CI Node version to 24.
.github/workflows/static-files.yml Updates CI Node version to 24.
.github/workflows/release.yml Updates CI Node version to 24.
.github/workflows/codeql-analysis.yml Updates CI Node version to 24.
.changeset/update-clipboard-copy-element.md Adds changeset for clipboard-copy-element bump.
.changeset/thirty-cougars-matter.md Adds changeset describing Dialog scroll-lock selector change.
.changeset/soft-stamps-camp.md Adds changeset describing render_in keyword-args acceptance.
Files not reviewed (1)
  • demo/package-lock.json: Generated file
Comments suppressed due to low confidence (1)

app/components/primer/beta/button_group.rb:114

  • This override captures keyword args but doesn't forward them to super. If render_in is invoked with keyword args (the reason for adding **_kwargs), they get dropped here, which can change behavior vs. the base implementation.
        def render_in(view_context, **_kwargs, &block)
          super(view_context) do
            block.call(@menu, @button)
          end
        end

Comment thread app/components/primer/dialog_helper.ts
Comment thread .github/workflows/test-components.yml
Comment thread .changeset/update-clipboard-copy-element.md Outdated
Comment thread .changeset/soft-stamps-camp.md
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

myabc and others added 3 commits July 9, 2026 17:22
Upstream's render_in kwargs change updated the beta and tree_view
components but not the OpenProject-namespaced PageHeader::Dialog and
PageHeader::Menu overrides, which would still raise if render_in is
called with keywords. Mirror the sibling pattern (accept and ignore
**_kwargs).
The range is `^1.3.1` and npm resolves it to 1.3.2, so the release
note now states the range rather than the exact upstream tag.
@myabc
myabc merged commit c8fa683 into main Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants