Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/components/primer/alpha/tree_view/tree_view.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {controller, target} from '@github/catalyst'
import {SelectStrategy, SelectVariant, TreeViewSubTreeNodeElement} from './tree_view_sub_tree_node_element'
import {type SelectStrategy, type SelectVariant, TreeViewSubTreeNodeElement} from './tree_view_sub_tree_node_element'
import {useRovingTabIndex} from './tree_view_roving_tab_index'
import type {TreeViewCheckedValue, TreeViewNodeInfo, TreeViewNodeType} from '../../shared_events'

Expand All @@ -24,7 +24,6 @@ export class TreeViewElement extends HTMLElement {
for (const addedNode of mutation.addedNodes) {
if (!(addedNode instanceof HTMLElement)) continue

// eslint-disable-next-line custom-elements/no-dom-traversal-in-connectedcallback
if (addedNode.querySelector('[aria-expanded=true]')) {
this.#autoExpandFrom(addedNode)
}
Expand Down Expand Up @@ -485,7 +484,6 @@ export class TreeViewElement extends HTMLElement {
updateHiddenFormInputs() {
const newInputs = []

// eslint-disable-next-line custom-elements/no-dom-traversal-in-connectedcallback
for (const node of this.querySelectorAll('[role=treeitem][aria-checked=true]')) {
const newInput = this.formInputPrototype.cloneNode() as HTMLInputElement
newInput.removeAttribute('data-target')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {controller} from '@github/catalyst'
import {CollapsibleElement} from '../collapsible'

@controller('collapsible-header')
class CollapsibleHeaderElement extends CollapsibleElement {
export class CollapsibleHeaderElement extends CollapsibleElement {
connectedCallback() {
if (!this.closest('.Box')) {
throw new Error('No surrounding BorderBox found')
Expand Down
2 changes: 1 addition & 1 deletion app/components/primer/open_project/collapsible_section.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {controller} from '@github/catalyst'
import {CollapsibleElement} from './collapsible'

@controller('collapsible-section')
class CollapsibleSectionElement extends CollapsibleElement {
export class CollapsibleSectionElement extends CollapsibleElement {
get baseClass(): string {
return 'CollapsibleSection'
}
Expand Down
1 change: 0 additions & 1 deletion app/components/primer/open_project/zen_mode_button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ class ZenModeButtonElement extends HTMLElement {
@target button: HTMLElement
inZenMode = false

// eslint-disable-next-line custom-elements/no-constructor
constructor() {
super()
document.addEventListener('fullscreenchange', this.fullscreenChangeEventHandler.bind(this))
Expand Down
Loading