add: possibility to have other backends in FakeAdagiosEnvironment#399
Open
matthieucan wants to merge 1 commit intoopinkerfi:masterfrom
Open
add: possibility to have other backends in FakeAdagiosEnvironment#399matthieucan wants to merge 1 commit intoopinkerfi:masterfrom
matthieucan wants to merge 1 commit intoopinkerfi:masterfrom
Conversation
This permits to drive Pynag with customised start/stop commands.
Contributor
Author
|
This is linked to pynag/pynag#155 |
Contributor
Author
|
Tests fail because they need Pynag patched with my latest pull request |
Contributor
There was a problem hiding this comment.
ENGINE_START_COMMAND and ENGINE_STOP_COMMAND both look like they should belong inside FakeShinkenEnvironment as per my comments on the pynag pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This permits to drive Pynag with customised start/stop commands.