Conversation
| ProxyPass ! | ||
| </Location> | ||
|
|
||
| <Location /adagios/> |
There was a problem hiding this comment.
Could you update the pull request with information on why this was needed?
It feels like this might cause subtle breakages for other use cases.
There was a problem hiding this comment.
This is only used if you run Adagios with Gunicorn and Apache. What use cases do you think will brake by using this?
| # If set, adagios will use this file to manage your object | ||
| # definitions. If set to None, adagios will search most common | ||
| # paths like /etc/nagios/nagios.cfg for it | ||
| #nagios_config = "/etc/nagios/nagios.cfg" |
There was a problem hiding this comment.
This is change required? Note the idea of having this commented out by default is for adagios to attempt to discover location of nagios.cfg in common locations and now that functionality becomes broken for default installs.
There was a problem hiding this comment.
yes maybe best to have this commented out by default. I will change this.
| @@ -0,0 +1,116 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I didn't look at the diff between adagios.conf and adagios_naemon.conf but are they significant?
I'm wondering what it would take to support naemon out of the box without having to fork the config file completely (this causes technical debt long term having to keep both config files in sync).
There was a problem hiding this comment.
I agree, best solution would be to support Naemon out of the box. I will look further into that.
Should fix ValueError: Expected string. Got <class 'list'>
|
2 participants
No description provided.