feat: add network interface capability#457
Merged
sandersms merged 8 commits intoopiproject:mainfrom Jan 20, 2025
Merged
Conversation
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # SPDX-License-Identifier: Apache-2.0 | ||
| # Copyright (c) 2022-2023 Dell Inc, or its subsidiaries. | ||
| FROM docker.io/library/golang:1.21.5-alpine3.17 as builder | ||
| FROM docker.io/library/golang:1.23.4-alpine3.21 as builder |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
| RUN go build -v -o /dpu . | ||
|
|
||
| FROM alpine:3.19 | ||
| FROM alpine:3.21 |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
artek-koltun
approved these changes
Jan 20, 2025
testing/mock-server/server/server.go
Outdated
| if resp.StatusCode != http.StatusOK { | ||
| body, _ := io.ReadAll(resp.Body) | ||
| return fmt.Errorf(string(body)) | ||
| return fmt.Errorf("%s", string(body)) |
Collaborator
There was a problem hiding this comment.
If you do not need to format error message, you can use errors.New
Contributor
Author
There was a problem hiding this comment.
good addition - changes made to address this particular issue.
| if err != nil { | ||
| log.Fatalf("could not create gRPC client: %v", err) | ||
| } | ||
| defer cancel() |
Collaborator
There was a problem hiding this comment.
would it make sense to create ctx and cancel right here and keep them close to this defer call?
Contributor
Author
There was a problem hiding this comment.
Will look at this one to determine if it needs to move or change in future addition.
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add network interface protobuf handling to go dpu cli.
Fixed several CI related error reports: