Skip to content

Pin golangci-lint version#7

Merged
artek-koltun merged 1 commit intoopiproject:mainfrom
han-minhee:fix-golangci-lint-error
Jul 8, 2025
Merged

Pin golangci-lint version#7
artek-koltun merged 1 commit intoopiproject:mainfrom
han-minhee:fix-golangci-lint-error

Conversation

@han-minhee
Copy link
Contributor

This patch pins the version of golangci-lint
as the lastest version gives a parsing error

@han-minhee han-minhee requested a review from a team as a code owner June 20, 2025 04:14
@han-minhee
Copy link
Contributor Author

I'll amend the commits soon

@han-minhee han-minhee force-pushed the fix-golangci-lint-error branch from 14cdea9 to 26fc0bd Compare June 30, 2025 09:16
@han-minhee
Copy link
Contributor Author

han-minhee commented Jun 30, 2025

I'm now working on enabling the Docker tests to run without errors

@han-minhee han-minhee force-pushed the fix-golangci-lint-error branch from 26fc0bd to 3d44c17 Compare July 1, 2025 05:02
@han-minhee
Copy link
Contributor Author

@artek-koltun I'm not sure what's causing the docker test to fail. Could you look into the issue? It works on my local environment.

# Copyright (c) 2022-2023 Dell Inc, or its subsidiaries.

FROM docker.io/library/golang:1.23.4-alpine3.21 as builder
FROM docker.io/library/golang:1.23.4-alpine3.21 AS builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: containerImage not pinned by hash
Click Remediation section below to solve this issue
@artek-koltun
Copy link

@artek-koltun I'm not sure what's causing the docker test to fail. Could you look into the issue? It works on my local environment.

ok, let's try to troubleshoot it. It says

No such image: opi-mangoboost-bridge-opi-mangoboost-server:latest

and I do not see that it even tried to build the image...
If you run locally what is the name of your image locally? opi-mangoboost-bridge-opi-mangoboost-server or maybe opi-mangoboost-bridge_opi-mangoboost-server?

@han-minhee
Copy link
Contributor Author

It's opi-mangoboost-bridge-opi-mangoboost-server,

I realized I should run SPDK separately before running opi-test, which isn't included in the docker-compose.
Should I include spdk in my docker-compose to pass the test?
I see no spdk included in intel's docker-compose file.

REPOSITORY                                    TAG                IMAGE ID       CREATED         SIZE
opi-mangoboost-bridge-opi-mangoboost-server   latest             5e620b69b6be   5 minutes ago   69.7MB

The containers during docker compose command:

 ✔ opi-mangoboost-server                                    Built       
 ✔ Network opi-mangoboost-bridge_opi                        Created     
 ✔ Container opi-mangoboost-bridge-jaeger-1                 Healthy     
 ✔ Container opi-mangoboost-bridge-redis-1                  Healthy     
 ✔ Container opi-mangoboost-bridge-opi-mangoboost-server-1  Healthy     
 ✔ Container opi-mangoboost-bridge-opi-gw-test-1            Exited      
 ✔ Container opi-mangoboost-bridge-opi-jaeger-test-1        Exited      
 ✔ Container opi-mangoboost-bridge-opi-test-1               Started

@artek-koltun
Copy link

artek-koltun commented Jul 4, 2025

It's opi-mangoboost-bridge-opi-mangoboost-server,

I realized I should run SPDK separately before running opi-test, which isn't included in the docker-compose. Should I include spdk in my docker-compose to pass the test? I see no spdk included in intel's docker-compose file.

REPOSITORY                                    TAG                IMAGE ID       CREATED         SIZE
opi-mangoboost-bridge-opi-mangoboost-server   latest             5e620b69b6be   5 minutes ago   69.7MB

The containers during docker compose command:

 ✔ opi-mangoboost-server                                    Built       
 ✔ Network opi-mangoboost-bridge_opi                        Created     
 ✔ Container opi-mangoboost-bridge-jaeger-1                 Healthy     
 ✔ Container opi-mangoboost-bridge-redis-1                  Healthy     
 ✔ Container opi-mangoboost-bridge-opi-mangoboost-server-1  Healthy     
 ✔ Container opi-mangoboost-bridge-opi-gw-test-1            Exited      
 ✔ Container opi-mangoboost-bridge-opi-jaeger-test-1        Exited      
 ✔ Container opi-mangoboost-bridge-opi-test-1               Started

No, you don't need to run spdk. Currently, docker-compose test just sends a list grpc request to the server and waits for response to make sure that the server is healthy.

The problem is that in the default version of docker compose 2.36.2, build is not performed. I will pin the version to 2.36.0 and get back to you

@sandersms
Copy link
Collaborator

I reviewed and merged the pinned docker compose version from @artek-koltun into the actions and requested the test to be re-run. It still is indicating the same error for the server functionality. I will take a look also and see if there is anything that I notice in the operation.

@artek-koltun
Copy link

Now, the job should contain Install Docker Compose v2.36.0 step, but I do not see it in the logs. @han-minhee can you pls try to force push? or open a new pr with the same change?

This patch pins golangci-lint to a specific version to avoid
parsing errors introduced in the latest release.

Signed-off-by: Han, Minhee <minhee.han@mangoboost.io>
@han-minhee han-minhee force-pushed the fix-golangci-lint-error branch from 3d44c17 to cee0fc7 Compare July 8, 2025 05:27
@han-minhee
Copy link
Contributor Author

Now, the job should contain Install Docker Compose v2.36.0 step, but I do not see it in the logs. @han-minhee can you pls try to force push? or open a new pr with the same change?

I've force pushed the commit.

@artek-koltun
Copy link

artek-koltun commented Jul 8, 2025

Now, the job should contain Install Docker Compose v2.36.0 step, but I do not see it in the logs. @han-minhee can you pls try to force push? or open a new pr with the same change?

I've force pushed the commit.

thanks. The test passed: https://github.com/opiproject/opi-mangoboost-bridge/actions/runs/16134766675/job/45535400632

@artek-koltun artek-koltun merged commit fd586ac into opiproject:main Jul 8, 2025
15 checks passed
@han-minhee han-minhee deleted the fix-golangci-lint-error branch July 8, 2025 08:39
@han-minhee
Copy link
Contributor Author

Thank you for your help, both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants