Conversation
|
I'll amend the commits soon |
14cdea9 to
26fc0bd
Compare
|
I'm now working on enabling the Docker tests to run without errors |
26fc0bd to
3d44c17
Compare
|
@artek-koltun I'm not sure what's causing the docker test to fail. Could you look into the issue? It works on my local environment. |
ok, let's try to troubleshoot it. It says and I do not see that it even tried to build the image... |
|
It's I realized I should run SPDK separately before running opi-test, which isn't included in the docker-compose. The containers during docker compose command: |
No, you don't need to run spdk. Currently, docker-compose test just sends a list grpc request to the server and waits for response to make sure that the server is healthy. The problem is that in the default version of docker compose 2.36.2, build is not performed. I will pin the version to 2.36.0 and get back to you |
|
I reviewed and merged the pinned docker compose version from @artek-koltun into the actions and requested the test to be re-run. It still is indicating the same error for the server functionality. I will take a look also and see if there is anything that I notice in the operation. |
|
Now, the job should contain Install Docker Compose v2.36.0 step, but I do not see it in the logs. @han-minhee can you pls try to force push? or open a new pr with the same change? |
This patch pins golangci-lint to a specific version to avoid parsing errors introduced in the latest release. Signed-off-by: Han, Minhee <minhee.han@mangoboost.io>
3d44c17 to
cee0fc7
Compare
I've force pushed the commit. |
thanks. The test passed: https://github.com/opiproject/opi-mangoboost-bridge/actions/runs/16134766675/job/45535400632 |
|
Thank you for your help, both of you! |
This patch pins the version of golangci-lint
as the lastest version gives a parsing error