Skip to content

Remove duplication in pagination#383

Open
artek-koltun wants to merge 7 commits intoopiproject:mainfrom
artek-koltun:feat-remove-duplication-in-pagination
Open

Remove duplication in pagination#383
artek-koltun wants to merge 7 commits intoopiproject:mainfrom
artek-koltun:feat-remove-duplication-in-pagination

Conversation

@artek-koltun
Copy link
Contributor

No description provided.

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #383 (5996f44) into main (7f4e06d) will decrease coverage by 3.16%.
The diff coverage is 82.69%.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   81.07%   77.91%   -3.16%     
==========================================
  Files          16       18       +2     
  Lines        2219     2314      +95     
==========================================
+ Hits         1799     1803       +4     
- Misses        379      468      +89     
- Partials       41       43       +2     
Impacted Files Coverage Δ
pkg/frontend/scsi.go 0.00% <0.00%> (ø)
pkg/server/utils.go 0.00% <ø> (ø)
pkg/frontend/nvme.go 88.46% <69.23%> (-1.06%) ⬇️
pkg/server/pagination.go 94.91% <94.91%> (ø)
pkg/backend/aio.go 95.60% <100.00%> (-0.15%) ⬇️
pkg/backend/backend.go 100.00% <100.00%> (ø)
pkg/backend/null.go 95.60% <100.00%> (-0.15%) ⬇️
pkg/backend/nvme.go 92.53% <100.00%> (-0.32%) ⬇️
pkg/frontend/blk.go 89.68% <100.00%> (-0.55%) ⬇️
pkg/frontend/frontend.go 69.56% <100.00%> (ø)
... and 3 more

@artek-koltun artek-koltun marked this pull request as ready for review May 24, 2023 14:59
@artek-koltun artek-koltun requested a review from a team as a code owner May 24, 2023 14:59
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ignoring this, I think there is a better option, let me try to present it in slack and we can discuss...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants