Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
==========================================
- Coverage 75.31% 74.46% -0.85%
==========================================
Files 40 41 +1
Lines 3622 3725 +103
==========================================
+ Hits 2728 2774 +46
- Misses 812 869 +57
Partials 82 82
|
artek-koltun
force-pushed
the
feat-graceful-shutdown
branch
2 times, most recently
from
34c1dfa to
c717377
Compare
glimchb
requested changes
Sep 15, 2023
Member
glimchb
left a comment
glimchb
left a comment
There was a problem hiding this comment.
need ore time to review it, so for being slow...
artek-koltun
force-pushed
the
feat-graceful-shutdown
branch
from
c717377 to
1841eca
Compare
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
artek-koltun
force-pushed
the
feat-graceful-shutdown
branch
from
1841eca to
dbad6e2
Compare
use simplified handling while waiting for golang/go#53757 Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #517