refactor: transtition to spdk client#875
Draft
artek-koltun wants to merge 11 commits intoopiproject:mainfrom
Draft
refactor: transtition to spdk client#875artek-koltun wants to merge 11 commits intoopiproject:mainfrom
artek-koltun wants to merge 11 commits intoopiproject:mainfrom
Conversation
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
ab6947e to
9f60d88
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 74.77% 74.19% -0.59%
==========================================
Files 40 41 +1
Lines 3699 3778 +79
==========================================
+ Hits 2766 2803 +37
- Misses 845 887 +42
Partials 88 88 ☔ View full report in Codecov by Sentry. |
9f60d88 to
cf34d3d
Compare
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
type name will be used as spdk.SpdkClientAdapter by other packages, and that stutters; consider calling this ClientAdapter Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spdk rolled out its own client, and we can start transition to that client from our custom solution
This PR is a first step of the integration.
An adapter struct between the new and old APIs was created in order to address the following obstacles:
Opens: