-
Notifications
You must be signed in to change notification settings - Fork 890
Services: Unbound DNS: Blocklist - CNAME and A record on query fix #7815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6586a65 to
607e32a
Compare
|
I don't mind merging, but can you share the documentation that you are referring to? |
DuckDuckGohttps://duckduckgo.com/duckduckgo-help-pages/features/safe-search/
Bing
Pixabayhttps://pixabay.com/blog/posts/block-adult-content-on-pixabay-at-your-school-or-w-140/
QwantI didn't find an official docs/blog but because the same problem was there I used the same way like on the other ones. |
|
but this doesn't explain why we are changing the redirect to transparent in |
|
Ah sorry, I meant I checked the exact domains again.
After some tests, this was the best solution to fix it and also the problem mentioned in #7301 without an explicit "whitelisting". |
bfdf0d3 to
968e5f9
Compare
wetono
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I can't access duckduckgo with safesearch enabled because of the problem you described (I'm using a Windows DNS server because of AD and have the OPNsense as the upstreams DNS, when the Windows DNS server caches the duckduckgo.com entry it only gives the client the safe.duckduckgo.com CNAME safe.duckduckgo.com and not the A-Record, so the client can't access duckduckgo), I'm glad to see there's a pull request that fixes this! I did some testing and have two small suggestions for improvement, but otherwise it works as intended!
src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
Outdated
Show resolved
Hide resolved
src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
Outdated
Show resolved
Hide resolved
src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
Outdated
Show resolved
Hide resolved
Co-authored-by: wetono <[email protected]>
Co-authored-by: wetono <[email protected]>
With the current zone settings, Unbound returns both, the A and CNAME (to it self) record on different safe search subdomains.
Affected subdomains:
safe.duckduckgo.comstrict.bing.comsafesearch.pixabay.comsafeapi.qwant.comThis commit fixes this issue.
I also checked this on official documentations to be as accurate as possible, so nothing else breaks again.