firewall/automation: Consolidate the stats column into a combined always visible one, implement cache invalidation via refresh button #9272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays visible one, implement cache invalidation via refresh button
fichtner
reviewed
Oct 8, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Outdated
Show resolved
Hide resolved
fichtner
reviewed
Oct 8, 2025
…ontroller.php Co-authored-by: Franco Fichtner <[email protected]>
Co-authored-by: Franco Fichtner <[email protected]>
fichtner
reviewed
Oct 8, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Outdated
Show resolved
Hide resolved
fichtner
approved these changes
Oct 8, 2025
…ontroller.php Co-authored-by: Franco Fichtner <[email protected]>
swhite2
reviewed
Oct 8, 2025
This was referenced Oct 8, 2025
…bootgrid since nothing in it is needed anymore
swhite2
requested changes
Oct 8, 2025
swhite2
approved these changes
Oct 8, 2025
…rmatted number in column and real full number in tooltip.
… no half bytes or half integers, this only matters if the base changed for better accuracy
…obal setting in filter_rule.volt so that no persistence is set on header clicks
Monviech
force-pushed
the
firewall-automation-cache
branch
from
0aae8cd to
bca426f
Compare
Monviech
force-pushed
the
firewall-automation-cache
branch
from
25e6e38 to
4989a46
Compare
fichtner
added a commit
that referenced
this pull request
Oct 20, 2025
…ays visible one, implement cache invalidation via refresh button (#9272) * firewall/automation: Consolidate the stats column into a combined always visible one, implement cache invalidation via refresh button * Update src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php Co-authored-by: Franco Fichtner <[email protected]> * Update src/opnsense/service/conf/actions.d/actions_filter.conf Co-authored-by: Franco Fichtner <[email protected]> * Update src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php Co-authored-by: Franco Fichtner <[email protected]> * Move event binding into headerFormatter, remove all loaded.rs.jquery.bootgrid since nothing in it is needed anymore * Make click handler safe * Include number formatter into byteFormat as parameter switch, show formatted number in column and real full number in tooltip. * Apply decimals if the base has been exceeded at least once, there are no half bytes or half integers, this only matters if the base changed for better accuracy * Flip this around * Split stats into two rows to safe on horizontal space * Fix duplicate headerSort in opnsense_bootgrid.js, push sortable to global setting in filter_rule.volt so that no persistence is set on header clicks * Add cache_ttl at correct spot --------- Co-authored-by: Franco Fichtner <[email protected]> (cherry picked from commit 5baba39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix the issue with showing and hiding columns in the most minimal way.
Reference to alternative: #9239