security/acme-client: Add automation support to restart Unbound #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for taking the time to submit this PR. However, I don't think that this new automation is necessary. There is already support for running generic configd commands in automations. To restart Unbound:
Would that be sufficient? :) (FWIW, I plan to remove the nginx/haproxy automations at some point in the future for the same reason.) |
Contributor
Author
|
Yeah, that works too ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With opnsense/core#5468 unbound will start using Acme certificates, thus we'll need automation support to restart unbound when the certificate gets updated.