Skip to content

security/tailscale: Set auth key to optional in UI #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheridans wants to merge 3 commits into
base: master
Choose a base branch
from
Open

security/tailscale: Set auth key to optional in UI #5065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b74fd78
security/tailscale make pre-auth key optional, allows use of AuthURL too
Dec 4, 2025
0abbd00
Updated pkg-descr to reflect optional auth key
Dec 4, 2025
c4ca2f0
bump version
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion security/tailscale/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PLUGIN_NAME= tailscale
PLUGIN_VERSION= 1.3
PLUGIN_VERSION= 1.4
PLUGIN_COMMENT= VPN mesh securely connecting clients using WireGuard
PLUGIN_DEPENDS= tailscale
PLUGIN_MAINTAINER= [email protected]
Expand Down
4 changes: 4 additions & 0 deletions security/tailscale/pkg-descr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ https://tailscale.com/
Plugin Changelog
================

1.4

* set pre-auth key field in UI to optional, enables registration via pre-auth key or AuthURL from status page

1.3

* modify RC script to prevent re-using auth key if already authenticated
Expand Down
2 changes: 1 addition & 1 deletion ...ty/tailscale/src/opnsense/mvc/app/controllers/OPNsense/Tailscale/forms/authentication.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<id>authentication.preAuthKey</id>
<label>Pre-authentication Key</label>
<type>text</type>
<help>Use a non-reusable auth key and disable expiration</help>
<help>Use a non-reusable auth key and disable expiration (optional). If not specified use AuthURL from Status page</help>
Copy link
Member

@fichtner fichtner Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you really want to bury it set it to advanced

Copy link
Contributor Author

@sheridans sheridans Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure on this, hiding it in advanced was my first thought. I do think it's right thing to do, but was thinking about what people are currently used to doing.

Copy link
Member

@fichtner fichtner Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also put this advanced flag on master only for 26.1 inclusion? so there is a bit more visibility for 2 more months

Copy link
Contributor Author

@sheridans sheridans Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good idea.

Copy link
Contributor Author

@sheridans sheridans Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good idea.

</field>
</form>
2 changes: 1 addition & 1 deletion security/tailscale/src/opnsense/mvc/app/models/OPNsense/Tailscale/Authentication.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<ValidationMessage>Please enter a valid URL</ValidationMessage>
</loginServer>
<preAuthKey type="TextField">
<Required>Y</Required>
<Required>N</Required>
</preAuthKey>
</items>
</model>