dns/dnscrypt-proxy: fix bootstrap_resolvers with multiple comma-separated servers #5163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address #5162
Problem
When multiple bootstrap resolvers are configured in the "Fallback Resolver" field (e.g.,
1.1.1.1:53,9.9.9.9:53), the template generates invalid TOML:This causes dnscrypt-proxy to fail to start with:
[FATAL] Bootstrap resolver [...]: Host does not parse as IP '1.1.1.1:53,9.9.9.9:53'Root Cause
This bug seems to have been introduced introduced in commit 1eec51a which renamed
fallback_resolver(a single string) tobootstrap_resolvers(a TOML array) but did not update the template syntax.Solution
Applied the same split/join pattern already used for
listen_addresses,server_names,disabled_server_names, andrelaylistin the same template file.Testing
Tested on OPNsense 25.7.10 with os-dnscrypt-proxy 1.16 - dnscrypt-proxy starts successfully with multiple bootstrap resolvers.