Fix #17219 Corrected the Fraction output logic#10
Fix #17219 Corrected the Fraction output logic#10HardikGoyal2003 wants to merge 10 commits intooppia:masterfrom
Conversation
|
@seanlip PTAL! Thanks! |
seanlip
left a comment
There was a problem hiding this comment.
@HardikGoyal2003 Which code am I actually supposed to review here? I don't see the source file(s) from which all these builds were generated, and I also don't understand why this has changed so much from the master branch. Could you please explain?
@seanlip I analysed and what I found is:
Thanks! |
This reverts commit a7409fd.
|
@seanlip PTAL! I have reverted the last commit and now test command has not been run but build command has been run and min.js has been edited manually. Thanks |
|
@HardikGoyal2003 This is a concern IMO. We need a standard build process that also updates the min.js file, and this should be documented in the PR template etc. What should that process be? What does the guppy project itself usually use? ("Manual changes" isn't an acceptable answer.) |
Overview
Essential Checklist
Proof that changes are correct
Screencast.from.02-03-24.12.21.14.AM.IST.webm
PR Pointers