Skip to content

Handle deleted user in the assignee list #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanlip merged 2 commits into from
Feb 1, 2025
Merged

Handle deleted user in the assignee list #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a279615
update condition
Feb 1, 2025
f7b97ae
Add comment
seanlip Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/github_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ def get_pull_request_dict_with_timestamp(
"""

for assignee in pr_dict['assignees']:
if event['assignee'] is None or assignee is None:
Copy link
Member

@seanlip seanlip Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevintab95 Could you please add a comment explaining the circumstances here before we merge this?

Copy link
Member

@seanlip seanlip Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update -- I went ahead and made the change.

# This situation can arise if a PR was reviewed by a now-deleted
# user.
continue
if event['assignee']['login'] == assignee['login']:
assignee['created_at'] = parser.parse(event['created_at'])
return pr_dict
Expand Down