Enhance SQL queries and tests for file-scoped unique constraints #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated SQL queries in `validate-state-mutation.primary-key.explain.txt` and `validate-state-mutation.unique-nested.explain.txt` to include `file_id` as a parameter for filtering. - Modified the explain plans to reflect changes in index usage for improved performance. - Added tests in `validate-state-mutation.playground.test.ts` and `vtable.test.ts` to validate the behavior of file-scoped unique constraints, ensuring that duplicates are allowed across different files. - Adjusted the query plans in `select-version-diff.playground-plan.txt` to incorporate `file_id` in relevant index searches.
|
samuelstroschein
temporarily deployed
to
staging
GitHub Actions
Inactive
samuelstroschein
temporarily deployed
to
indeces-for-constraints - lix-docs PR #3750
Render
Destroyed
|
View your CI Pipeline Execution ↗ for commit 334f404
☁️ Nx Cloud last updated this comment at |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds file-aware PK/unique indexing and configurable foreign-key scope, plus a new
(version_id, entity_id)index; updates tests and bench plans accordingly.idx_<table>_veon(version_id, entity_id)increate-schema-cache-table.ts.buildSchemaIndexSpecsto includefile_idin PK/unique index expressions and support configurable FKscope(defaultversion_id,file_id).schema-indexes.ts; add normalization for FK scope.file_idand new column orders; add test ensuring FK respects custom scope.lix_internal_state_vtable...._ve, file-scoped index suffixes) and addedfile_idpredicates in validation queries.Written by Cursor Bugbot for commit 334f404. This will update automatically on new commits. Configure here.