Add-plugin-md-readme #3761
Add-plugin-md-readme #3761
Conversation
- Fix observe invalidation for file queries to prevent stale data. - Update README for clarity and quick start instructions. - Refactor code for better readability and maintainability. - Add tests for observing file changes and extracting filters.
…improve clarity and consistency in descriptions.
🦋 Changeset detectedLatest commit: 48ed0de The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
samuelstroschein
temporarily deployed
to
staging
GitHub Actions
Inactive
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --nx-bail --target=build --parallel |
✅ Succeeded | 41s | View ↗ |
nx run-many --target=test --parallel |
✅ Succeeded | 32s | View ↗ |
nx run-many --target=lint --parallel |
✅ Succeeded | 2s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-23 18:43:37 UTC
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const nodeId of childrenOrder) { | ||
| // First check if the node exists in the current document content | ||
| const existingNode = document.content.find( | ||
| (node) => (node.attrs?.id || node._id) === nodeId, | ||
| (node) => node.attrs?.id === nodeId, | ||
| ); |
There was a problem hiding this comment.
applyDocumentOrder now matches top-level nodes only by attrs.id, whereas previous versions (and the README that still mentions legacy _id support) accepted either attrs.id or _id. Existing documents persisted with _id but no attrs.id will no longer be found in the existing content or the node map, so rehydrating a file after this change will silently drop or reorder those nodes when changes are applied. Without a migration/normalization step, upgrading will lose content for any snapshots that relied on _id identifiers.
Useful? React with 👍 / 👎.
samuelstroschein
temporarily deployed
to
add-plugin-md-readme - prosemirror-example PR #3761
Render
Destroyed
samuelstroschein
temporarily deployed
to
staging
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…id columns as file_id - Introduced a new test case for extractLiteralFilters to validate that joined id columns are correctly identified and not misclassified as file_id. - Updated extractLiteralFilters function to handle table aliases and improve column reference extraction logic. - Refactored table name extraction to support alias mapping for better accuracy in filter extraction.
samuelstroschein
temporarily deployed
to
add-plugin-md-readme - lix-docs PR #3761
Render
Destroyed
samuelstroschein
temporarily deployed
to
staging
GitHub Actions
Inactive
…pnpm-workspace.yaml to streamline package management.
samuelstroschein
temporarily deployed
to
staging
GitHub Actions
Inactive
Note
Fixes file observe invalidation to re-emit on state commits touching the same file, strengthens ProseMirror plugin (empty data, ID handling) with tests and example UI tweaks, and updates JSON/Markdown plugin READMEs.
file_id(improves invalidation offilereads).extractLiteralFiltersto capturefile_idand respect table aliases; refine schema-key detection; add targeted tests.applyChangesstarts from an empty doc when file data is empty; remove legacy_idhandling in schemas/diff logic.applyChanges/detectChanges; expand test coverage.OpfsSahEnvironment.clear(); hide proposals tab; version toolbar adds "Merge to main" flow.@lix-js/plugin-json,@lix-js/plugin-md, and@lix-js/plugin-prosemirrorwith install, quick start, and behavior details.Written by Cursor Bugbot for commit 48ed0de. This will update automatically on new commits. Configure here.